On Wed, 13 Jan 2021 10:46:26 +0800 leirao <lei....@intel.com> wrote: > From: "Rao, Lei" <lei....@intel.com> > > There is the same trace code in the colo_compare_packet_payload. > > Signed-off-by: Lei Rao <lei....@intel.com>
Looks good to me,
Reviewed-by: Lukas Straub <lukasstra...@web.de>
> ---
> net/colo-compare.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/net/colo-compare.c b/net/colo-compare.c
> index 84db497..9e18baa 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -590,19 +590,6 @@ static int colo_packet_compare_other(Packet *spkt,
> Packet *ppkt)
> uint16_t offset = ppkt->vnet_hdr_len;
>
> trace_colo_compare_main("compare other");
> - if (trace_event_get_state_backends(TRACE_COLO_COMPARE_IP_INFO)) {
> - char pri_ip_src[20], pri_ip_dst[20], sec_ip_src[20], sec_ip_dst[20];
> -
> - strcpy(pri_ip_src, inet_ntoa(ppkt->ip->ip_src));
> - strcpy(pri_ip_dst, inet_ntoa(ppkt->ip->ip_dst));
> - strcpy(sec_ip_src, inet_ntoa(spkt->ip->ip_src));
> - strcpy(sec_ip_dst, inet_ntoa(spkt->ip->ip_dst));
> -
> - trace_colo_compare_ip_info(ppkt->size, pri_ip_src,
> - pri_ip_dst, spkt->size,
> - sec_ip_src, sec_ip_dst);
> - }
> -
> if (ppkt->size != spkt->size) {
> trace_colo_compare_main("Other: payload size of packets are
> different");
> return -1;
--
pgpxvu_Kp7Q3h.pgp
Description: OpenPGP digital signature
