Patchew URL: https://patchew.org/QEMU/1611113349-24906-1-git-send-email-tsimp...@quicinc.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1611113349-24906-1-git-send-email-tsimp...@quicinc.com Subject: [PATCH v7 00/35] Hexagon patch series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1611113349-24906-1-git-send-email-tsimp...@quicinc.com -> patchew/1611113349-24906-1-git-send-email-tsimp...@quicinc.com Switched to a new branch 'test' c335702 Add Dockerfile for hexagon 8661b0b Hexagon build infrastructure ccb9289 Hexagon (tests/tcg/hexagon) TCG tests - floating point 59a4aa2 Hexagon (tests/tcg/hexagon) TCG tests - atomics/load/store/misc df41b51 Hexagon (tests/tcg/hexagon) TCG tests - multiarch 24e4a9b Hexagon (linux-user/hexagon) Linux user emulation ba53aef Hexagon (target/hexagon) translation d73903b Hexagon (target/hexagon) TCG for floating point instructions e1b871e Hexagon (target/hexagon) TCG for instructions with multiple definitions 785ab07 Hexagon (target/hexagon) TCG generation e2a6bd3 Hexagon (target/hexagon) instruction classes f7caea3 Hexagon (target/hexagon) macros 3602875 Hexagon (target/hexagon) opcode data structures 0aff0a5 Hexagon (target/hexagon) generater phase 4 - decode tree 8ce6152 Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree 5282602 Hexagon (target/hexagon) generator phase 2 - generate header files ddb1ab6 Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics cec03ae Hexagon (target/hexagon/imported) arch import 0a394da Hexagon (target/hexagon/fma_emu.[ch]) utility functions a52a115 Hexagon (target/hexagon/conv_emu.[ch]) utility functions ea5667d Hexagon (target/hexagon/arch.[ch]) utility functions d9071c2 Hexagon (target/hexagon) instruction printing fedaa51 Hexagon (target/hexagon) instruction/packet decode 0eeb24a Hexagon (target/hexagon) instruction attributes 132ac36 Hexagon (target/hexagon) register fields d4dd36b Hexagon (target/hexagon) instruction and packet types 0349f20 Hexagon (target/hexagon) architecture types 09e562e Hexagon (target/hexagon) GDB Stub a6c4da7 Hexagon (target/hexagon) scalar core helpers acea93d Hexagon (target/hexagon) register names e7ad833 Hexagon (disas) disassembler 499c323 Hexagon (target/hexagon) scalar core definition 03a6080 Hexagon (include/elf.h) ELF machine definition 119b184 Hexagon (target/hexagon) README 41b2cc4 Hexagon Update MAINTAINERS file === OUTPUT BEGIN === 1/35 Checking commit 41b2cc46bddd (Hexagon Update MAINTAINERS file) 2/35 Checking commit 119b184919b0 (Hexagon (target/hexagon) README) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 235 lines checked Patch 2/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/35 Checking commit 03a6080a087d (Hexagon (include/elf.h) ELF machine definition) 4/35 Checking commit 499c32330043 (Hexagon (target/hexagon) scalar core definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 595 lines checked Patch 4/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/35 Checking commit e7ad833e1ae3 (Hexagon (disas) disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 total: 0 errors, 1 warnings, 79 lines checked Patch 5/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/35 Checking commit acea93de4673 (Hexagon (target/hexagon) register names) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 83 lines checked Patch 6/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/35 Checking commit a6c4da758966 (Hexagon (target/hexagon) scalar core helpers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 1151 lines checked Patch 7/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/35 Checking commit 09e562e6ea3f (Hexagon (target/hexagon) GDB Stub) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33: new file mode 100644 total: 0 errors, 1 warnings, 64 lines checked Patch 8/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/35 Checking commit 0349f20a8d56 (Hexagon (target/hexagon) architecture types) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 38 lines checked Patch 9/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/35 Checking commit d4dd36b33785 (Hexagon (target/hexagon) instruction and packet types) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 74 lines checked Patch 10/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/35 Checking commit 132ac36288e3 (Hexagon (target/hexagon) register fields) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #84: FILE: target/hexagon/reg_fields.h:29: +#define DEF_REG_FIELD(TAG, START, WIDTH) \ + TAG, total: 1 errors, 1 warnings, 104 lines checked Patch 11/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/35 Checking commit 0eeb24a76299 (Hexagon (target/hexagon) instruction attributes) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #41: FILE: target/hexagon/attribs.h:22: +#define DEF_ATTRIB(NAME, ...) A_##NAME, total: 1 errors, 1 warnings, 125 lines checked Patch 12/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/35 Checking commit fedaa5184a64 (Hexagon (target/hexagon) instruction/packet decode) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #132: FILE: target/hexagon/decode.c:101: +#define DECODE_SEPARATOR_BITS(START, WIDTH) NULL, START, WIDTH ERROR: Macros with multiple statements should be enclosed in a do - while loop #714: FILE: target/hexagon/q6v_decode.c:51: +#define DECODE_OPINFO(TAG, BEH) \ + case TAG: \ + { BEH } \ + break; \ + total: 2 errors, 1 warnings, 1005 lines checked Patch 13/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/35 Checking commit d9071c2319cb (Hexagon (target/hexagon) instruction printing) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 ERROR: Macros with multiple statements should be enclosed in a do - while loop #63: FILE: target/hexagon/printinsn.c:43: +#define DEF_PRINTINFO(TAG, FMT, ...) \ + case TAG: \ + g_string_append_printf(buf, FMT, __VA_ARGS__); \ + break; total: 1 errors, 1 warnings, 174 lines checked Patch 14/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/35 Checking commit ea5667da5711 (Hexagon (target/hexagon/arch.[ch]) utility functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 329 lines checked Patch 15/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/35 Checking commit a52a1158a755 (Hexagon (target/hexagon/conv_emu.[ch]) utility functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 208 lines checked Patch 16/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/35 Checking commit 0a394da3d06d (Hexagon (target/hexagon/fma_emu.[ch]) utility functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 ERROR: "foo * bar" should be "foo *bar" #411: FILE: target/hexagon/fma_emu.c:392: +static inline SUFFIX accum_round_##SUFFIX(Accum a, float_status * fp_status) \ WARNING: Block comments use a leading /* on a separate line #415: FILE: target/hexagon/fma_emu.c:396: + /* result zero */ \ WARNING: Block comments use a leading /* on a separate line #423: FILE: target/hexagon/fma_emu.c:404: + /* Normalize right */ \ WARNING: Block comments use a leading /* on a separate line #424: FILE: target/hexagon/fma_emu.c:405: + /* We want MANTBITS bits of mantissa plus the leading one. */ \ WARNING: Block comments use a leading /* on a separate line #425: FILE: target/hexagon/fma_emu.c:406: + /* That means that we want MANTBITS+1 bits, or 0x000000000000FF_FFFF */ \ WARNING: Block comments use a leading /* on a separate line #426: FILE: target/hexagon/fma_emu.c:407: + /* So we need to normalize right while the high word is non-zero and \ WARNING: Block comments should align the * on each line #427: FILE: target/hexagon/fma_emu.c:408: + /* So we need to normalize right while the high word is non-zero and \ + * while the low word is nonzero when masked with 0xffe0_0000_0000_0000 */ \ WARNING: Block comments use a leading /* on a separate line #432: FILE: target/hexagon/fma_emu.c:413: + /* \ WARNING: Block comments use a leading /* on a separate line #442: FILE: target/hexagon/fma_emu.c:423: + /* \ WARNING: Block comments use a leading /* on a separate line #449: FILE: target/hexagon/fma_emu.c:430: + /* \ WARNING: Block comments use a leading /* on a separate line #458: FILE: target/hexagon/fma_emu.c:439: + /* OK, we're relatively canonical... now we need to round */ \ WARNING: Block comments use a leading /* on a separate line #463: FILE: target/hexagon/fma_emu.c:444: + /* Chop and we're done */ \ WARNING: Block comments use a leading /* on a separate line #477: FILE: target/hexagon/fma_emu.c:458: + /* round up if guard is 1, down if guard is zero */ \ WARNING: Block comments use a leading /* on a separate line #480: FILE: target/hexagon/fma_emu.c:461: + /* exactly .5, round up if odd */ \ WARNING: Block comments use a leading /* on a separate line #486: FILE: target/hexagon/fma_emu.c:467: + /* \ WARNING: Block comments use a leading /* on a separate line #495: FILE: target/hexagon/fma_emu.c:476: + /* Overflow? */ \ WARNING: Block comments use a leading /* on a separate line #497: FILE: target/hexagon/fma_emu.c:478: + /* Yep, inf result */ \ WARNING: Block comments use a leading /* on a separate line #519: FILE: target/hexagon/fma_emu.c:500: + /* Underflow? */ \ WARNING: Block comments use a leading /* on a separate line #521: FILE: target/hexagon/fma_emu.c:502: + /* Leading one means: No, we're normal. So, we should be done... */ \ total: 1 errors, 19 warnings, 739 lines checked Patch 17/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/35 Checking commit cec03ae97ecc (Hexagon (target/hexagon/imported) arch import) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #44: new file mode 100644 total: 0 errors, 1 warnings, 9228 lines checked Patch 18/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/35 Checking commit ddb1ab6dee24 (Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 ERROR: suspicious ; after while (0) #86: FILE: target/hexagon/gen_semantics.c:61: + } while (0); total: 1 errors, 1 warnings, 88 lines checked Patch 19/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/35 Checking commit 52826027551a (Hexagon (target/hexagon) generator phase 2 - generate header files) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #44: new file mode 100755 WARNING: line over 80 characters #1002: FILE: target/hexagon/gen_tcg_funcs.py:53: + f.write(" tcg_gen_mov_tl(hex_new_value[%s + 1], hex_gpr[%s + 1]);\n" % \ WARNING: line over 80 characters #1083: FILE: target/hexagon/gen_tcg_funcs.py:134: + f.write(" TCGv %s%sN = hex_new_pred_value[insn->regno[%d]];\n" % \ WARNING: line over 80 characters #1165: FILE: target/hexagon/gen_tcg_funcs.py:216: + f.write(" hex_gpr[%s%sN + 1]);\n" % \ WARNING: line over 80 characters #1264: FILE: target/hexagon/gen_tcg_funcs.py:315: + f.write(" gen_log_predicated_reg_write_pair(%s%sN, %s%sV, insn->slot);\n" % \ total: 0 errors, 5 warnings, 1600 lines checked Patch 20/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/35 Checking commit 8ce6152d4206 (Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #67: FILE: target/hexagon/gen_dectree_import.c:44: +#define Q6INSN(TAG, BEH, ATTRIBS, DESCR, SEM) \ + [TAG] = BEH, ERROR: Macros with complex values should be enclosed in parenthesis #69: FILE: target/hexagon/gen_dectree_import.c:46: +#define EXTINSN(TAG, BEH, ATTRIBS, DESCR, SEM) \ + [TAG] = BEH, ERROR: Macros with complex values should be enclosed in parenthesis #77: FILE: target/hexagon/gen_dectree_import.c:54: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS, ERROR: Macros with complex values should be enclosed in parenthesis #86: FILE: target/hexagon/gen_dectree_import.c:63: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS, ERROR: suspicious ; after while (0) #183: FILE: target/hexagon/gen_dectree_import.c:160: + } while (0); total: 5 errors, 1 warnings, 187 lines checked Patch 21/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/35 Checking commit 0aff0a58365f (Hexagon (target/hexagon) generater phase 4 - decode tree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100755 total: 0 errors, 1 warnings, 351 lines checked Patch 22/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/35 Checking commit 36028753de95 (Hexagon (target/hexagon) opcode data structures) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #60: FILE: target/hexagon/opcodes.c:41: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) REGINFO, ERROR: Macros with complex values should be enclosed in parenthesis #70: FILE: target/hexagon/opcodes.c:51: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS, ERROR: Macros with complex values should be enclosed in parenthesis #80: FILE: target/hexagon/opcodes.c:61: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS, ERROR: Macros with complex values should be enclosed in parenthesis #88: FILE: target/hexagon/opcodes.c:69: +#define DEF_SHORTCODE(TAG, SHORTCODE) [TAG] = #SHORTCODE, ERROR: Macros with complex values should be enclosed in parenthesis #127: FILE: target/hexagon/opcodes.c:108: +#define ATTRIBS(...) , ## __VA_ARGS__, 0 total: 5 errors, 1 warnings, 205 lines checked Patch 23/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/35 Checking commit f7caea393849 (Hexagon (target/hexagon) macros) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 591 lines checked Patch 24/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/35 Checking commit e2a6bd30a4cc (Hexagon (target/hexagon) instruction classes) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #45: FILE: target/hexagon/iclass.c:23: +#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS) \ + [ICLASS_FROM_TYPE(TYPE)] = SLOTS_##SLOTS, ERROR: Macros with complex values should be enclosed in parenthesis #47: FILE: target/hexagon/iclass.c:25: +#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS) \ + [ICLASS_FROM_TYPE(TYPE)] = SLOTS_##SLOTS, ERROR: Macros with complex values should be enclosed in parenthesis #128: FILE: target/hexagon/iclass.h:27: +#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS) ICLASS_FROM_TYPE(TYPE), ERROR: Macros with complex values should be enclosed in parenthesis #129: FILE: target/hexagon/iclass.h:28: +#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS) ICLASS_FROM_TYPE(TYPE), total: 4 errors, 1 warnings, 174 lines checked Patch 25/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/35 Checking commit 785ab0787814 (Hexagon (target/hexagon) TCG generation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 261 lines checked Patch 26/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 27/35 Checking commit e1b871e51505 (Hexagon (target/hexagon) TCG for instructions with multiple definitions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 198 lines checked Patch 27/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 28/35 Checking commit d73903bf0709 (Hexagon (target/hexagon) TCG for floating point instructions) 29/35 Checking commit ba53aef06611 (Hexagon (target/hexagon) translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 784 lines checked Patch 29/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 30/35 Checking commit 24e4a9b6fb0d (Hexagon (linux-user/hexagon) Linux user emulation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead #139: FILE: linux-user/hexagon/cpu_loop.c:76: + EXCP_DUMP(env, "\nqemu: unhandled CPU exception %#x - aborting\n", total: 1 errors, 1 warnings, 1039 lines checked Patch 30/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/35 Checking commit df41b51024cb (Hexagon (tests/tcg/hexagon) TCG tests - multiarch) ERROR: line over 90 characters #36: FILE: tests/tcg/configure.sh:99: + alpha|cris|hexagon|hppa|i386|lm32|microblaze|microblazeel|m68k|openrisc|riscv64|s390x|sh4|sparc64) ERROR: Missing Signed-off-by: line(s) total: 2 errors, 0 warnings, 1562 lines checked Patch 31/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/35 Checking commit 59a4aa2de096 (Hexagon (tests/tcg/hexagon) TCG tests - atomics/load/store/misc) ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 1150 lines checked Patch 32/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/35 Checking commit ccb9289f36f2 (Hexagon (tests/tcg/hexagon) TCG tests - floating point) ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 376 lines checked Patch 33/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/35 Checking commit 8661b0bb6d8e (Hexagon build infrastructure) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 WARNING: line over 80 characters #63: FILE: scripts/qemu-binfmt-conf.sh:139: +hexagon_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xa4\x00' ERROR: line over 90 characters #64: FILE: scripts/qemu-binfmt-conf.sh:140: +hexagon_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff' total: 1 errors, 2 warnings, 220 lines checked Patch 34/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 35/35 Checking commit c33570293762 (Add Dockerfile for hexagon) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 WARNING: line over 80 characters #109: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:63: + -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic --target=hexagon-unknown-linux-musl " \ ERROR: line over 90 characters #136: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:90: + CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ ERROR: line over 90 characters #173: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:127: + CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ total: 2 errors, 2 warnings, 170 lines checked Patch 35/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1611113349-24906-1-git-send-email-tsimp...@quicinc.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com