Gerd Hoffmann <kra...@redhat.com> writes: > On 09/01/11 21:37, Anthony Liguori wrote: >> On 09/01/2011 10:42 AM, Gerd Hoffmann wrote: >>> Probe for libcheck and build checks (if found) by default. >>> Can be explicitly disabled using --disable-check-utests. >>> >>> Signed-off-by: Gerd Hoffmann<kra...@redhat.com> >>> --- >>> configure | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> I think we should convert the check tests to gtest, and then have make >> check use gtester and gtester-report generate a single report of all of >> the test cases. > > I wouldn't object, that is *way* beyond the scope of this little patch > series though.
One step at a time. >> We could then have build bot run make check and post the output. > > Running "make check" in buildbot is indeed the motivation to do this ;) > >> I don't >> want to end up with a bunch of non gtest unit tests... > > This patch series doesn't add any. Yep. If you want to standardize on gtest, you get to convert or remove the existing tests. Until then, we use what we have. > It just adds some build system > glue so "make check" runs the existing stuff. Running self-tests shouldn't be made any harder than that.
