On Wed, Jan 06, 2021 at 01:02:39PM +0000, Daniel P. Berrangé wrote: > All variables are 64-bit and so %l / %ll are not required, and the > latter is actually invalid: > > $ sudo stap -e 'probe begin{printf ("BEGIN")}' -I . > parse error: invalid or missing conversion specifier > saw: operator ',' at ./qemu-system-x86_64-log.stp:15118:101 > source: printf("%d@%d vhost_vdpa_set_log_base dev: %p base: 0x%x > size: %llu > refcnt: %d fd: %d log: %p\n", pid(), gettimeofday_ns(), dev, base, size, > refcnt, fd, log) > > ^ > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > --- > scripts/tracetool/format/log_stap.py | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > In v2: > > - Change existing logic that stripped %z to handle %l/%ll too
Thanks, applied to my tracing tree with Laurent's typo fix: https://gitlab.com/stefanha/qemu/commits/tracing Stefan
signature.asc
Description: PGP signature