On 1/8/21 1:02 PM, Stefano Garzarella wrote: > On Thu, Dec 10, 2020 at 06:28:34PM +0100, Philippe Mathieu-Daudé wrote: >> Replace I/O write error reported with error_report() by >> qemu_log_mask(GUEST_ERROR) which allow filtering. >> >> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> --- >> hw/virtio/virtio-pci.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c >> index f863f69ede4..094c36aa3ea 100644 >> --- a/hw/virtio/virtio-pci.c >> +++ b/hw/virtio/virtio-pci.c >> @@ -27,6 +27,7 @@ >> #include "hw/qdev-properties.h" >> #include "qapi/error.h" >> #include "qemu/error-report.h" > ^ > Just a little thing, could we remove this inclusion since we are not > using error_report() anymore in this file?
We can't because virtio_pci_device_plugged() calls warn_report() twice :/ > Anyway the patch LGTM: > > Reviewed-by: Stefano Garzarella <sgarz...@redhat.com> Thanks! Phil.
