Am 02.09.2011 17:29, schrieb Markus Armbruster: > Kevin Wolf <kw...@redhat.com> writes: > >> Am 03.08.2011 15:08, schrieb Markus Armbruster: >>> Need to ask the device, so this requires new BlockDevOps member >>> is_medium_ejected(). >>> >>> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> >> I find the name confusing. "medium is ejected" seems to mean "tray is >> open". It isn't obvious that "tray is closed, but no medium is inserted" >> is not "medium is ejected". >> >> Why not call it tray_open like in the devices? > > Not all all devices with removable media have trays. I'll rename it > anyway. We'll figure out how to handle devices without trays when we > add one.
Then you need to clarify the intended semantics. For devices without a tray it's completely unclear to me what it means. The example for such a device that we have today is floppy. Kevin
