We already have a generic PCI_FUNC() macro in "hw/pci/pci.h" to extract the PCI function identifier, use it.
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Acked-by: David Gibson <da...@gibson.dropbear.id.au> Message-Id: <20201012124506.3406909-4-phi...@redhat.com> --- hw/pci-host/uninorth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/uninorth.c b/hw/pci-host/uninorth.c index 0c0a9ecee14..f0a4d8c7178 100644 --- a/hw/pci-host/uninorth.c +++ b/hw/pci-host/uninorth.c @@ -63,7 +63,7 @@ static uint32_t unin_get_config_reg(uint32_t reg, uint32_t addr) if (slot == 32) { slot = -1; /* XXX: should this be 0? */ } - func = (reg >> 8) & 7; + func = PCI_FUNC(reg >> 8); /* ... and then convert them to x86 format */ /* config pointer */ -- 2.26.2