Patchew URL: https://patchew.org/QEMU/20201219105532.1734134-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201219105532.1734134-1-arm...@redhat.com Subject: [PULL 00/33] QAPI patches patches for 2020-12-19 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201219105532.1734134-1-arm...@redhat.com -> patchew/20201219105532.1734134-1-arm...@redhat.com * [new tag] patchew/20201219111934.5540-1-mark.cave-ayl...@ilande.co.uk -> patchew/20201219111934.5540-1-mark.cave-ayl...@ilande.co.uk Switched to a new branch 'test' 50cf88f qobject: Make QString immutable 219adc3f block: Use GString instead of QString to build filenames 6b26586 keyval: Use GString to accumulate value strings c201d84 json: Use GString instead of QString to accumulate strings 7f3b372 migration: Replace migration's JSON writer by the general one 528861f qobject: Factor JSON writer out of qobject_to_json() 2ec5364 qobject: Factor quoted_str() out of to_json() 3c6b4e4 qobject: Drop qstring_get_try_str() e9a5862 qobject: Drop qobject_get_try_str() 5355c0b Revert "qobject: let object_property_get_str() use new API" bb79759 block: Avoid qobject_get_try_str() 682d4a2 qmp: Fix tracing of non-string command IDs 94fb9f2 qobject: Move internals to qobject-internal.h c35e746 hw/rdma: Replace QList by GQueue ce6552d Revert "qstring: add qstring_free()" 92a214e qobject: Change qobject_to_json()'s value to GString 9300d4f qobject: Use GString instead of QString to accumulate JSON 83c58e9 qobject: Make qobject_to_json_pretty() take a pretty argument cae34720 monitor: Use GString instead of QString for output buffer 5ce523f hmp: Simplify how qmp_human_monitor_command() gets output d00c4a9 test-visitor-serialization: Clean up test_primitives() 1f20720 test-visitor-serialization: Drop insufficient precision workaround 08e5179 string-output-visitor: Fix to use sufficient precision f6b278a test-string-output-visitor: Cover "unround" number 0c5456e qobject: Fix qnum_to_string() to use sufficient precision 99709b5 tests/check-qnum: Cover qnum_to_string() for "unround" argument b9f996e tests/check-qjson: Replace redundant large_number() 5395cbb tests/check-qjson: Cover number 2^63 772a54f tests/check-qjson: Examine QNum more thoroughly e4decd9 tests/check-qjson: Don't skip funny QNumber to JSON conversions 3b10bb6 qapi: Use QAPI_LIST_PREPEND() where possible 1a5e6e4 migration: Refactor migrate_cap_add b197a61 rocker: Revamp fp_port_get_info === OUTPUT BEGIN === 1/33 Checking commit b197a61caecb (rocker: Revamp fp_port_get_info) 2/33 Checking commit 1a5e6e4a2c9f (migration: Refactor migrate_cap_add) 3/33 Checking commit 3b10bb662508 (qapi: Use QAPI_LIST_PREPEND() where possible) 4/33 Checking commit e4decd945ac8 (tests/check-qjson: Don't skip funny QNumber to JSON conversions) WARNING: Block comments use a leading /* on a separate line #95: FILE: tests/check-qjson.c:883: + { "-32.20e-10", -32.20e-10, "-0" /* BUG */ }, ERROR: spaces required around that '-' (ctx:VxV) #95: FILE: tests/check-qjson.c:883: + { "-32.20e-10", -32.20e-10, "-0" /* BUG */ }, ^ total: 1 errors, 1 warnings, 97 lines checked Patch 4/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/33 Checking commit 772a54f1cf5a (tests/check-qjson: Examine QNum more thoroughly) 6/33 Checking commit 5395cbbe7df9 (tests/check-qjson: Cover number 2^63) 7/33 Checking commit b9f996e8a2e1 (tests/check-qjson: Replace redundant large_number()) 8/33 Checking commit 99709b586e03 (tests/check-qnum: Cover qnum_to_string() for "unround" argument) 9/33 Checking commit 0c5456ea8d00 (qobject: Fix qnum_to_string() to use sufficient precision) WARNING: Block comments use a leading /* on a separate line #105: FILE: qobject/qnum.c:170: + /* FIXME: g_strdup_printf() is locale dependent; but JSON requires ERROR: spaces required around that '-' (ctx:VxV) #145: FILE: tests/check-qjson.c:886: + { "-32.20e-10", -32.20e-10, "-3.22e-09" }, ^ total: 1 errors, 1 warnings, 69 lines checked Patch 9/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/33 Checking commit f6b278afee74 (test-string-output-visitor: Cover "unround" number) 11/33 Checking commit 08e5179b5f93 (string-output-visitor: Fix to use sufficient precision) 12/33 Checking commit 1f20720448a4 (test-visitor-serialization: Drop insufficient precision workaround) 13/33 Checking commit d00c4a954141 (test-visitor-serialization: Clean up test_primitives()) 14/33 Checking commit 5ce523f11a05 (hmp: Simplify how qmp_human_monitor_command() gets output) 15/33 Checking commit cae347203dc0 (monitor: Use GString instead of QString for output buffer) 16/33 Checking commit 83c58e9ffed3 (qobject: Make qobject_to_json_pretty() take a pretty argument) 17/33 Checking commit 9300d4fa9d19 (qobject: Use GString instead of QString to accumulate JSON) 18/33 Checking commit 92a214e26b4a (qobject: Change qobject_to_json()'s value to GString) 19/33 Checking commit ce6552d76f07 (Revert "qstring: add qstring_free()") 20/33 Checking commit c35e74638490 (hw/rdma: Replace QList by GQueue) 21/33 Checking commit 94fb9f20fafc (qobject: Move internals to qobject-internal.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #174: new file mode 100644 total: 0 errors, 1 warnings, 154 lines checked Patch 21/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/33 Checking commit 682d4a256ac4 (qmp: Fix tracing of non-string command IDs) 23/33 Checking commit bb7975901234 (block: Avoid qobject_get_try_str()) 24/33 Checking commit 5355c0bf5b9c (Revert "qobject: let object_property_get_str() use new API") 25/33 Checking commit e9a5862af1f9 (qobject: Drop qobject_get_try_str()) 26/33 Checking commit 3c6b4e48200a (qobject: Drop qstring_get_try_str()) 27/33 Checking commit 2ec536474768 (qobject: Factor quoted_str() out of to_json()) 28/33 Checking commit 528861fbbca4 (qobject: Factor JSON writer out of qobject_to_json()) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 total: 0 errors, 1 warnings, 487 lines checked Patch 28/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 29/33 Checking commit 7f3b3727f6e9 (migration: Replace migration's JSON writer by the general one) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #287: deleted file mode 100644 total: 0 errors, 1 warnings, 751 lines checked Patch 29/33 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 30/33 Checking commit c201d84dff3d (json: Use GString instead of QString to accumulate strings) 31/33 Checking commit 6b2658627db3 (keyval: Use GString to accumulate value strings) 32/33 Checking commit 219adc3f7f9e (block: Use GString instead of QString to build filenames) 33/33 Checking commit 50cf88f55262 (qobject: Make QString immutable) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201219105532.1734134-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
