Markus Armbruster <arm...@redhat.com> writes: > Eric Blake <ebl...@redhat.com> writes: > >> v1, as such, was here: >> https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg08003.html >> (v6 11/11 qapi: Use QAPI_LIST_ADD() where possible) >> >> since then, I've rebased that patch (upstream went with PREPEND >> instead of ADD), split things out for easier review, added >> QAPI_LIST_APPEND, caught a lot more places that can use PREPEND, and >> even fixed a years-old memory leak that might be worth having in 5.2. >> But patches 2-7 are 6.0 material. > [...] >> 55 files changed, 431 insertions(+), 1007 deletions(-) > > Lovely. These two macros are obviously overdue.
I'm queuing PATCH 2-4. We concluced PATCH 1 isn't necessary. PATCH 7 needs work, and I gather you'd like to improve PATCH 5 (parenthesis in macro expansion) and 6 (use the opportunity to improve variable naming). > Series needs a rebase. The conflicts are due to a8aa94b5f8 qga: update schema for guest-get-disks 'dependents' field a10b453a52 target/mips: Move mips_cpu_add_definition() from helper.c to cpu.c and easy enough to resolve for me. Thanks!