From: Pan Nengyuan <pannengy...@huawei.com>

'local_err' seems forgot to propagate in error path, it'll cause
a memleak. Fix it.

Reported-by: Euler Robot <euler.ro...@huawei.com>
Signed-off-by: Pan Nengyuan <pannengy...@huawei.com>
Reviewed-by: Kevin Wolf <kw...@redhat.com>
Reviewed-by: Li Qiang <liq...@gmail.com>
Signed-off-by: Chen Qun <kuhn.chen...@huawei.com>
Message-Id: <20201023061218.2080844-7-kuhn.chen...@huawei.com>
Signed-off-by: Laurent Vivier <laur...@vivier.eu>
---
 blockdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/blockdev.c b/blockdev.c
index 412354b4b6ac..2431448c5d41 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1827,6 +1827,7 @@ static void drive_backup_prepare(BlkActionState *common, 
Error **errp)
     if (set_backing_hd) {
         bdrv_set_backing_hd(target_bs, source, &local_err);
         if (local_err) {
+            error_propagate(errp, local_err);
             goto unref;
         }
     }
-- 
2.29.2


Reply via email to