Re: [PATCH] ui: add support for remote power control to VNC server

[Gerd Hoffmann]

On Fri, Dec 11, 2020 at 04:08:25PM +0000, Daniel P. Berrangé wrote:
> The "XVP" (Xen VNC Proxy) extension defines a mechanism for a VNC client
> to issue power control requests to trigger graceful shutdown, reboot, or
> hard reset.

Looks good.  Any other clients are supporting this?

> +            case VNC_XVP_ACTION_REBOOT:
> +                send_xvp_message(vs, VNC_XVP_CODE_FAIL);
> +                break;

> +            default:
> +                send_xvp_message(vs, VNC_XVP_CODE_FAIL);
> +                break;

Minor nit:

These two are identical, so you can drop the first.

take care,
  Gerd