Patchew URL: https://patchew.org/QEMU/20201212155530.23098-1-cfont...@suse.de/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201212155530.23098-1-cfont...@suse.de Subject: [PATCH v12 00/23] i386 cleanup PART 1 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu a4b307b..ad717e6 master -> master - [tag update] patchew/20201210134752.780923-1-marcandre.lur...@redhat.com -> patchew/20201210134752.780923-1-marcandre.lur...@redhat.com - [tag update] patchew/20201211152426.350966-1-th...@redhat.com -> patchew/20201211152426.350966-1-th...@redhat.com * [new tag] patchew/20201212155530.23098-1-cfont...@suse.de -> patchew/20201212155530.23098-1-cfont...@suse.de Switched to a new branch 'test' c993002 cpu: move do_unaligned_access to tcg_ops 1fcfced cpu: move cc->transaction_failed to tcg_ops cee04d2 cpu: move cc->do_interrupt to tcg_ops 958a66b target/arm: do not use cc->do_interrupt for KVM directly d6f1e88 cpu: Move debug_excp_handler to tcg_ops 6bd0b6d cpu: Move tlb_fill to tcg_ops dceed35 cpu: Move cpu_exec_* to tcg_ops a26bcc5 cpu: Move synchronize_from_tb() to tcg_ops d2b9509 accel/tcg: split TCG-only code from cpu_exec_realizefn f9929c6 target/riscv: remove CONFIG_TCG, as it is always TCG 69f0499 cpu: Introduce TCGCpuOperations struct 8b288bd cpu: Remove unnecessary noop methods a661f58 tcg: Make CPUClass.debug_excp_handler optional fd59765 tcg: make CPUClass.cpu_exec_* optional df0bced tcg: cpu_exec_{enter,exit} helpers 302f7ca i386: tcg: remove inline from cpu_load_eflags c043739 i386: move TCG cpu class initialization to tcg/ cdaa57f i386: move cpu dump out of helper.c into cpu-dump.c b0ec6c2 i386: move TCG accel files into tcg/ 7157bb9 i386: hvf: remove stale MAINTAINERS entry for old hvf stubs e35e8ed i386: move hax accel files into hax/ 8f492a2 i386: move whpx accel files into whpx/ 6af631f i386: move kvm accel files into kvm/ === OUTPUT BEGIN === 1/23 Checking commit 6af631fd810a (i386: move kvm accel files into kvm/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #169: rename from target/i386/hyperv-proto.h total: 0 errors, 1 warnings, 150 lines checked Patch 1/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/23 Checking commit 8f492a2bf426 (i386: move whpx accel files into whpx/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 35 lines checked Patch 2/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/23 Checking commit e35e8eda6f11 (i386: move hax accel files into hax/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: rename from target/i386/hax-all.c total: 0 errors, 1 warnings, 47 lines checked Patch 3/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/23 Checking commit 7157bb9b1377 (i386: hvf: remove stale MAINTAINERS entry for old hvf stubs) 5/23 Checking commit b0ec6c29e4b7 (i386: move TCG accel files into tcg/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #49: rename from target/i386/bpt_helper.c total: 0 errors, 1 warnings, 39 lines checked Patch 5/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/23 Checking commit cdaa57f74dd0 (i386: move cpu dump out of helper.c into cpu-dump.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 ERROR: braces {} are necessary for all arms of this statement #130: FILE: target/i386/cpu-dump.c:113: + if (!(env->hflags & HF_PE_MASK) || !(sc->flags & DESC_P_MASK)) [...] WARNING: Block comments use a leading /* on a separate line #174: FILE: target/i386/cpu-dump.c:157: +/* ARRAY_SIZE check is not required because WARNING: Block comments use a leading /* on a separate line #213: FILE: target/i386/cpu-dump.c:196: +/* ARRAY_SIZE check is not required because ERROR: line over 90 characters #375: FILE: target/i386/cpu-dump.c:358: + qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n" ERROR: line over 90 characters #376: FILE: target/i386/cpu-dump.c:359: + "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n" ERROR: line over 90 characters #377: FILE: target/i386/cpu-dump.c:360: + "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n" ERROR: line over 90 characters #378: FILE: target/i386/cpu-dump.c:361: + "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n" ERROR: line over 90 characters #379: FILE: target/i386/cpu-dump.c:362: + "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n", ERROR: space required before the open parenthesis '(' #438: FILE: target/i386/cpu-dump.c:421: + for(i = 0; i < 6; i++) { WARNING: line over 80 characters #450: FILE: target/i386/cpu-dump.c:433: + qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n", ERROR: space required before the open parenthesis '(' #455: FILE: target/i386/cpu-dump.c:438: + for(i = 0; i < 4; i++) ERROR: braces {} are necessary for all arms of this statement #455: FILE: target/i386/cpu-dump.c:438: + for(i = 0; i < 4; i++) [...] ERROR: space required before the open parenthesis '(' #471: FILE: target/i386/cpu-dump.c:454: + for(i = 0; i < 4; i++) { ERROR: braces {} are necessary for all arms of this statement #478: FILE: target/i386/cpu-dump.c:461: + if ((unsigned)env->cc_op < CC_OP_NB) [...] + else [...] WARNING: line over 80 characters #479: FILE: target/i386/cpu-dump.c:462: + snprintf(cc_op_name, sizeof(cc_op_name), "%s", cc_op_str[env->cc_op]); ERROR: space required before the open parenthesis '(' #499: FILE: target/i386/cpu-dump.c:482: + for(i = 0; i < 8; i++) { ERROR: spaces required around that '=' (ctx:VxV) #509: FILE: target/i386/cpu-dump.c:492: + for(i=0;i<8;i++) { ^ ERROR: space required after that ';' (ctx:VxV) #509: FILE: target/i386/cpu-dump.c:492: + for(i=0;i<8;i++) { ^ ERROR: spaces required around that '<' (ctx:VxV) #509: FILE: target/i386/cpu-dump.c:492: + for(i=0;i<8;i++) { ^ ERROR: space required after that ';' (ctx:VxV) #509: FILE: target/i386/cpu-dump.c:492: + for(i=0;i<8;i++) { ^ ERROR: space required before the open parenthesis '(' #509: FILE: target/i386/cpu-dump.c:492: + for(i=0;i<8;i++) { ERROR: braces {} are necessary for all arms of this statement #514: FILE: target/i386/cpu-dump.c:497: + if ((i & 1) == 1) [...] + else [...] ERROR: braces {} are necessary for all arms of this statement #519: FILE: target/i386/cpu-dump.c:502: + if (env->hflags & HF_CS64_MASK) [...] + else [...] ERROR: spaces required around that '=' (ctx:VxV) #523: FILE: target/i386/cpu-dump.c:506: + for(i=0;i<nb;i++) { ^ ERROR: space required after that ';' (ctx:VxV) #523: FILE: target/i386/cpu-dump.c:506: + for(i=0;i<nb;i++) { ^ ERROR: spaces required around that '<' (ctx:VxV) #523: FILE: target/i386/cpu-dump.c:506: + for(i=0;i<nb;i++) { ^ ERROR: space required after that ';' (ctx:VxV) #523: FILE: target/i386/cpu-dump.c:506: + for(i=0;i<nb;i++) { ^ ERROR: space required before the open parenthesis '(' #523: FILE: target/i386/cpu-dump.c:506: + for(i=0;i<nb;i++) { ERROR: braces {} are necessary for all arms of this statement #530: FILE: target/i386/cpu-dump.c:513: + if ((i & 1) == 1) [...] + else [...] total: 25 errors, 5 warnings, 1077 lines checked Patch 6/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/23 Checking commit c0437394ad3a (i386: move TCG cpu class initialization to tcg/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #416: new file mode 100644 total: 0 errors, 1 warnings, 596 lines checked Patch 7/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/23 Checking commit 302f7ca47f5f (i386: tcg: remove inline from cpu_load_eflags) 9/23 Checking commit df0bced0380b (tcg: cpu_exec_{enter,exit} helpers) 10/23 Checking commit fd5976575069 (tcg: make CPUClass.cpu_exec_* optional) 11/23 Checking commit a661f58cc91c (tcg: Make CPUClass.debug_excp_handler optional) 12/23 Checking commit 8b288bd57129 (cpu: Remove unnecessary noop methods) 13/23 Checking commit 69f0499d618c (cpu: Introduce TCGCpuOperations struct) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #94: new file mode 100644 total: 0 errors, 1 warnings, 301 lines checked Patch 13/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/23 Checking commit f9929c61a623 (target/riscv: remove CONFIG_TCG, as it is always TCG) 15/23 Checking commit d2b950994b26 (accel/tcg: split TCG-only code from cpu_exec_realizefn) 16/23 Checking commit a26bcc5ec783 (cpu: Move synchronize_from_tb() to tcg_ops) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #76: rename from include/hw/core/tcg-cpu-ops.h total: 0 errors, 1 warnings, 182 lines checked Patch 16/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/23 Checking commit dceed35dc50d (cpu: Move cpu_exec_* to tcg_ops) 18/23 Checking commit 6bd0b6d27c75 (cpu: Move tlb_fill to tcg_ops) 19/23 Checking commit d6f1e8860230 (cpu: Move debug_excp_handler to tcg_ops) 20/23 Checking commit 958a66b1d37b (target/arm: do not use cc->do_interrupt for KVM directly) 21/23 Checking commit cee04d26e38b (cpu: move cc->do_interrupt to tcg_ops) 22/23 Checking commit 1fcfced0d53f (cpu: move cc->transaction_failed to tcg_ops) 23/23 Checking commit c993002c8e6e (cpu: move do_unaligned_access to tcg_ops) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201212155530.23098-1-cfont...@suse.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
