On 12/9/20 10:31 AM, Philippe Mathieu-Daudé wrote:
> On 12/8/20 8:48 PM, Claudio Fontana wrote:
>> Signed-off-by: Claudio Fontana <cfont...@suse.de>
>> ---
> ...
>> diff --git a/include/hw/core/tcg-cpu-ops.h b/include/hw/core/tcg-cpu-ops.h
>> index 6b9b72e785..0cc0927738 100644
>> --- a/include/hw/core/tcg-cpu-ops.h
>> +++ b/include/hw/core/tcg-cpu-ops.h
>
> Missing (for MemTxAttrs/MemTxResult):
>
> #include "exec/memattrs.h"
right, this is included only from cpu.h though, which already does it, should
we still repeat the include here?
Thanks,
Claudio
>
>> @@ -40,6 +40,15 @@ typedef struct TcgCpuOperations {
>> /** @do_interrupt: Callback for interrupt handling. */
>> void (*do_interrupt)(CPUState *cpu);
>>
>> + /**
>> + * @do_transaction_failed: Callback for handling failed memory
>> transactions
>> + * (ie bus faults or external aborts; not MMU faults)
>> + */
>> + void (*do_transaction_failed)(CPUState *cpu, hwaddr physaddr, vaddr
>> addr,
>> + unsigned size, MMUAccessType access_type,
>> + int mmu_idx, MemTxAttrs attrs,
>> + MemTxResult response, uintptr_t retaddr);
>> +
> ...
>
>
