Claudio Fontana <cfont...@suse.de> writes:
> split up the CpusAccel tcg_cpus into three TCG variants: > > tcg_cpus_rr (single threaded, round robin cpus) > tcg_cpus_icount (same as rr, but with instruction counting enabled) > tcg_cpus_mttcg (multi-threaded cpus) > <snip> > diff --git a/accel/tcg/tcg-cpus-mttcg.c b/accel/tcg/tcg-cpus-mttcg.c > new file mode 100644 > index 0000000000..dac724fc85 > --- /dev/null > +++ b/accel/tcg/tcg-cpus-mttcg.c > @@ -0,0 +1,117 @@ <snip> > + > +/* > + * In the multi-threaded case each vCPU has its own thread. The TLS > + * variable current_cpu can be used deep in the code to find the > + * current CPUState for a given thread. > + */ > + <snip> > + > +/* > + * In the multi-threaded case each vCPU has its own thread. The TLS > + * variable current_cpu can be used deep in the code to find the > + * current CPUState for a given thread. > + */ nit: This is overly repetitive - I think we can drop the duplication in the header. If anything the comment should probably be re-formulated at the current_cpu definition in cpus-common. <snip> Otherwise nice clean-up ;-) Reviewed-by: Alex Bennée <alex.ben...@linaro.org> -- Alex Bennée
