Patchew URL: https://patchew.org/QEMU/20201208001727.17433-1-mcr...@linux.microsoft.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201208001727.17433-1-mcr...@linux.microsoft.com Subject: [PATCH] linux-user: add option to chroot before emulation === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201208001727.17433-1-mcr...@linux.microsoft.com -> patchew/20201208001727.17433-1-mcr...@linux.microsoft.com Switched to a new branch 'test' 939b01d linux-user: add option to chroot before emulation === OUTPUT BEGIN === ERROR: do not use assignment in if condition #62: FILE: linux-user/main.c:707: + if ((fp = fopen("/proc/sys/vm/mmap_min_addr", "r")) != NULL) { ERROR: space prohibited between function name and open parenthesis '(' #88: FILE: linux-user/main.c:733: + target_argv = calloc(target_argc + 1, sizeof (char *)); total: 2 errors, 0 warnings, 158 lines checked Commit 939b01d16330 (linux-user: add option to chroot before emulation) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201208001727.17433-1-mcr...@linux.microsoft.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com