On 11/23/20 9:44 PM, Philippe Mathieu-Daudé wrote: > Since v1: > - Addressed Richard review comments > > Patches missing review: 1,3,4,21,22,25 > > Hi, > > This series, while boring, helps maintainability. > > I simply exploded 60% of the huge target/mips/translate.c, > reducing it from 32K lines of code to 13500. > > The small overhead in the diffstat is due to entries added in > MAINTAINERS and license boilerplate addition: > 20225 insertions(+), 19987 deletions(-) > > While being a massive diff, it is a no-brain review using > 'git-diff --color-moved=dimmed-zebra' which highlights very few > changes: #include and license lines. > > The exploded new layout, which allows more useful filtering > with the get_maintainer.pl script, is: > > - MIPS ISA, ASE and modules: > > . isa-micromips_helper.h.inc > . isa-nanomips_translate.c.inc > > . ase-mips16e_translate.c.inc > > . mod-dsp_helper.c > . mod-dsp_helper.h.inc > . mod-dsp_translate.c.inc > . mod-msa_helper.h.inc > . mod-msa_translate.c.inc > . mod-msa_helper.c > . mod-mt_helper.h.inc > > - MIPS Vendor Specific: > > . vendor-loong-simd_helper.c > . vendor-loong-ext_translate.c.inc > . vendor-loong-simd_helper.h.inc > . vendor-loong-simd_translate.c.inc > > . vendor-tx-mmi_translate.c.inc > . vendor-tx_translate.c.inc > > . vendor-vr54xx_helper.c > . vendor-vr54xx_helper.h.inc > . vendor-vr54xx_translate.c.inc > > . vendor-mxu_translate.c.inc > > There should be no logical code change (only code movement). > > The series is available at: > > https://gitlab.com/philmd/qemu.git tags/mips_translate_explode-v2 > > Regards, > > Phil. > > Philippe Mathieu-Daudé (28): > target/mips: Use FloatRoundMode enum for FCR31 modes conversion > target/mips: Extract FPU helpers to 'fpu_helper.h'
Patches 1 and 2 queued to mips-next.
