> -----Original Message----- > From: Pankaj Gupta [mailto:pankaj.gupta.li...@gmail.com] > Sent: Friday, December 4, 2020 3:13 PM > To: ganqixin <ganqi...@huawei.com> > Cc: Qemu Developers <qemu-devel@nongnu.org>; > qemu-triv...@nongnu.org; Chenqun (kuhn) > <kuhn.chen...@huawei.com>; th...@redhat.com; Zhanghailiang > <zhang.zhanghaili...@huawei.com>; Michael S . Tsirkin <m...@redhat.com> > Subject: Re: [PATCH v2 01/12] pc-dimm: put it into the 'storage' category > > > mdc->get_memory_region = > pc_dimm_md_get_memory_region; > > > > mdc->fill_device_info = pc_dimm_md_fill_device_info; > > > > + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); > > > > > > Any reason why pc-dimm would be in the storage category? > ... > > Thanks for you reply. As far as I know, pc-dimm is a dimm device for > memory hotplug, described as a "DIMM memory module" in "-device > help". > > This device looks related to storage, so I put it into the "storage" > category to make it easy to find. I'm not sure if this is appropriate, do you > have any better ideas? > > O.k. I see storage & memory as different devices. Since we don't have any > memory device type defined, maybe its okay to put it in MISC device.
You're right. Maybe I should send a separate patch to add the "memory" category and move the memory device from "uncategorized" and "misc" to "memory". Thanks, Gan Qixin > > Thanks, > Pankaj
