On Thu, Dec 3, 2020 at 3:17 PM Gerd Hoffmann <kra...@redhat.com> wrote:
> vnc stopped using the copyrect pseudo encoding in 2017, in commit
> 50628d3479e4 ("cirrus/vnc: zap bitblit support from console code.")
> So we can drop the now unused copyrect feature bit.
>
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
---
> ui/vnc.h | 2 --
> ui/vnc.c | 3 ---
> 2 files changed, 5 deletions(-)
>
> diff --git a/ui/vnc.h b/ui/vnc.h
> index 262fcf179b44..a7fd38a82075 100644
> --- a/ui/vnc.h
> +++ b/ui/vnc.h
> @@ -445,7 +445,6 @@ enum VncFeatures {
> VNC_FEATURE_WMVI,
> VNC_FEATURE_TIGHT,
> VNC_FEATURE_ZLIB,
> - VNC_FEATURE_COPYRECT,
> VNC_FEATURE_RICH_CURSOR,
> VNC_FEATURE_TIGHT_PNG,
> VNC_FEATURE_ZRLE,
> @@ -459,7 +458,6 @@ enum VncFeatures {
> #define VNC_FEATURE_WMVI_MASK (1 << VNC_FEATURE_WMVI)
> #define VNC_FEATURE_TIGHT_MASK (1 << VNC_FEATURE_TIGHT)
> #define VNC_FEATURE_ZLIB_MASK (1 << VNC_FEATURE_ZLIB)
> -#define VNC_FEATURE_COPYRECT_MASK (1 << VNC_FEATURE_COPYRECT)
> #define VNC_FEATURE_RICH_CURSOR_MASK (1 <<
> VNC_FEATURE_RICH_CURSOR)
> #define VNC_FEATURE_TIGHT_PNG_MASK (1 << VNC_FEATURE_TIGHT_PNG)
> #define VNC_FEATURE_ZRLE_MASK (1 << VNC_FEATURE_ZRLE)
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 49235056f7a8..8c2771c1ce3b 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -2061,9 +2061,6 @@ static void set_encodings(VncState *vs, int32_t
> *encodings, size_t n_encodings)
> case VNC_ENCODING_RAW:
> vs->vnc_encoding = enc;
> break;
> - case VNC_ENCODING_COPYRECT:
> - vs->features |= VNC_FEATURE_COPYRECT_MASK;
> - break;
> case VNC_ENCODING_HEXTILE:
> vs->features |= VNC_FEATURE_HEXTILE_MASK;
> vs->vnc_encoding = enc;
> --
> 2.27.0
>
>
>
--
Marc-André Lureau
