Re: [PATCH 28/29] vl: remove separate preconfig main_loop

[Paolo Bonzini]

On 20/11/20 17:26, Igor Mammedov wrote:

+    if (!preconfig_requested) {
+        qmp_x_exit_preconfig(&error_fatal);
+    }
+    qemu_init_displays();

given that qemu_init_displays() were called in both cases,
shouldn't it be called unconditionally at [1]?

Yes, makes sense.  In fact, it would be nicer to also call

    accel_setup_post(current_machine);
    os_setup_post();

before x_exit_preconfig, but it's left for another day.

Paolo