Patchew URL: https://patchew.org/QEMU/20201120161622.1537-1-vsement...@virtuozzo.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201120161622.1537-1-vsement...@virtuozzo.com Subject: [PATCH RFC 0/5] Fix accidental crash in iotest 30 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201120161622.1537-1-vsement...@virtuozzo.com -> patchew/20201120161622.1537-1-vsement...@virtuozzo.com Switched to a new branch 'test' 9aed580 block: protect some graph-modifyng things by mutex 74c4557 block: move some mirror and stream handlers to coroutine fae70bd scripts/block-coroutine-wrapper.py: allow more function types 7bccf2c iotest-30-shorten: concentrate on failing test case 1c79f08 abort-on-set-to-true === OUTPUT BEGIN === 1/5 Checking commit 1c79f086eae8 (abort-on-set-to-true) ERROR: do not initialise globals to 0 or NULL #18: FILE: block.c:87: +bool abort_on_set_to_true = false; ERROR: line over 90 characters #27: FILE: block.c:2007: + if ((added_perms || removed_shared_perms) && tighten_restrictions == &abort_on_set_to_true) { WARNING: line over 80 characters #44: FILE: block.c:2075: + ret = bdrv_child_check_perm(c, q, cur_perm, cur_shared, ignore_children, WARNING: line over 80 characters #47: FILE: block.c:2078: + ret = bdrv_child_check_perm(c, q, cur_perm, cur_shared, ignore_children, WARNING: line over 80 characters #48: FILE: block.c:2079: + tighten_restrictions ? &child_tighten_restr total: 2 errors, 3 warnings, 74 lines checked Patch 1/5 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/5 Checking commit 7bccf2cf8bff (iotest-30-shorten: concentrate on failing test case) 3/5 Checking commit fae70bd3851a (scripts/block-coroutine-wrapper.py: allow more function types) WARNING: line over 80 characters #35: FILE: scripts/block-coroutine-wrapper.py:82: +func_decl_re = re.compile(r'^(?P<return_type>(void|int))\s*generated_co_wrapper\s*' total: 0 errors, 1 warnings, 80 lines checked Patch 3/5 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/5 Checking commit 74c4557e6dea (block: move some mirror and stream handlers to coroutine) 5/5 Checking commit 9aed58093018 (block: protect some graph-modifyng things by mutex) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201120161622.1537-1-vsement...@virtuozzo.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
