> -----Original Message----- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Tuesday, November 17, 2020 2:59 PM > To: Philippe Mathieu-Daudé <phi...@redhat.com> > Cc: ganqixin <ganqi...@huawei.com>; qemu-devel@nongnu.org; > qemu-triv...@nongnu.org; Marc-André Lureau > <marcandre.lur...@redhat.com>; th...@redhat.com; Chenqun (kuhn) > <kuhn.chen...@huawei.com>; Zhanghailiang > <zhang.zhanghaili...@huawei.com>; Eduardo Habkost > <ehabk...@redhat.com> > Subject: Re: [PATCH 09/13] u2f-passthru: put it into the 'usb' category > > On Mon, Nov 16, 2020 at 03:04:52PM +0100, Philippe Mathieu-Daudé > wrote: > > On 11/15/20 7:48 PM, Gan Qixin wrote: > > > The category of the u2f-passthru device is not set, put it into the 'usb' > > > category. > > > > I guess we discussed this with Thomas 1 or 2 years ago but I don't > > remember. I think it was about using set_bits() so devices can appear > > in multiple categories. > > > > Gerd, do you know what is the point of the "usb" category for > > management apps? This is a bus accepting multiple better categorized > > devices (display, storage, input, network, sound). > > Right now we have the host adapters collected in the usb category. > Maybe we should rename the category to make that clear. > > And, yes, tagging the u2f devices as "usb" doesn't look useful. > > > Unrelated but multiple devices are related to SECURITY. > > Maybe it is time to introduce the DEVICE_CATEGORY_SECURITY? > > Either that, or place it in the "misc" category.
Thanks for your advice, I will put it into 'misc' category. Gan Qixin
