On 13/11/2020 07.12, Markus Armbruster wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes, with the changes > to the following files manually reverted: > > contrib/libvhost-user/libvhost-user-glib.h > contrib/libvhost-user/libvhost-user.c > contrib/libvhost-user/libvhost-user.h > contrib/plugins/hotblocks.c > contrib/plugins/hotpages.c > contrib/plugins/howvec.c > contrib/plugins/lockstep.c > linux-user/mips64/cpu_loop.c > linux-user/mips64/signal.c > linux-user/sparc64/cpu_loop.c > linux-user/sparc64/signal.c > linux-user/x86_64/cpu_loop.c > linux-user/x86_64/signal.c > target/s390x/gen-features.c > tests/fp/platform.h > tests/migration/s390x/a-b-bios.c > tests/plugin/bb.c > tests/plugin/empty.c > tests/plugin/insn.c > tests/plugin/mem.c > tests/test-rcu-simpleq.c > tests/test-rcu-slist.c > tests/test-rcu-tailq.c > tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.c > > contrib/plugins/, tests/plugin/, and tests/test-rcu-slist.c appear not > to include osdep.h intentionally. The remaining reverts are the same > as in commit bbfff19688d. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > No real need to get this into 5.2 at this stage. No real risk either.
Seems to compile fine: https://gitlab.com/huth/qemu/-/pipelines/215598144 https://cirrus-ci.com/build/6127772462481408 https://travis-ci.com/github/huth/qemu/builds/201194948 Tested-by: Thomas Huth <th...@redhat.com>