On Wed, Nov 11, 2020 at 08:57:16AM -0500, Paolo Bonzini wrote: > -set as far as I can see has basically no use. It was intended as an override > mechanism for configuration files, but even configuration files themselves > are hardly used. Drop it with prejudice. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > docs/system/deprecated.rst | 6 ++++++ > include/qemu/config-file.h | 1 - > qemu-options.hx | 9 --------- > softmmu/vl.c | 4 ---- > util/qemu-config.c | 33 --------------------------------- > 5 files changed, 6 insertions(+), 47 deletions(-)
iotest 068 uses -set and qtest vhost-user-text.c also does IOW, it looks like it is valid to use -set, even if you're not using -readconfig. Libvirt doesn't use -set, but we've had users who make use of libvirt command line passthrough for QEMU with -set. IOW, I'm not convinced real world usage is near zero as suggested. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
