The vhost-user-blk server test was already in Michael Tsirkin's recent vhost
pull request, but was dropped because it exposed vhost-user regressions
(b7c1bd9d7848 and the Based-on tag below). Now that the vhost-user regressions
are fixed we can re-introduce the test case.
This series adds missing input validation that led to a Coverity report. The
virtio-blk read, write, discard, and write zeroes commands need to check
sector/byte ranges and other inputs. This solves the issue Peter Maydell raised
in "[PATCH for-5.2] block/export/vhost-user-blk-server.c: Avoid potential
integer overflow".
Merging just the input validation patches would be possible too, but I prefer
to merge the corresponding tests so the code is exercised by the CI.
Based-on: 20201109174355.1069147-1-stefa...@redhat.com ("[PATCH for-5.2]
vhost-user: fix VHOST_USER_ADD/REM_MEM_REG truncation")
Coiby Xu (1):
test: new qTest case to test the vhost-user-blk-server
Stefan Hajnoczi (9):
tests/qtest: add multi-queue test case to vhost-user-blk-test
libqtest: add qtest_socket_server()
vhost-user-blk-test: rename destroy_drive() to destroy_file()
vhost-user-blk-test: close fork child file descriptors
vhost-user-blk-test: drop unused return value
vhost-user-blk-test: fix races by using fd passing
block/export: port virtio-blk discard/write zeroes input validation
vhost-user-blk-test: test discard/write zeroes invalid inputs
block/export: port virtio-blk read/write range check
tests/qtest/libqos/libqtest.h | 25 +
tests/qtest/libqos/vhost-user-blk.h | 48 ++
block/export/vhost-user-blk-server.c | 129 +++-
tests/qtest/libqos/vhost-user-blk.c | 129 ++++
tests/qtest/libqtest.c | 76 ++-
tests/qtest/vhost-user-blk-test.c | 965 +++++++++++++++++++++++++++
tests/qtest/libqos/meson.build | 1 +
tests/qtest/meson.build | 2 +
8 files changed, 1333 insertions(+), 42 deletions(-)
create mode 100644 tests/qtest/libqos/vhost-user-blk.h
create mode 100644 tests/qtest/libqos/vhost-user-blk.c
create mode 100644 tests/qtest/vhost-user-blk-test.c
--
2.28.0
