On 11/10/20 6:11 PM, Stefan Hajnoczi wrote:
> I interpreted CONFIG_VHOST_USER as controlling only QEMU's vhost-user
> device frontends. However, virtiofsd and contrib/ vhost-user device
> backends are also controlled by CONFIG_VHOST_USER. Make the
> vhost-user-blk server depend on CONFIG_VHOST_USER for consistency.

Possible follow up cleanup is to rename variable including
"frontend/backend".

Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com>

> 
> Now the following error is printed when the vhost-user-blk server is
> enabled without CONFIG_VHOST_USER:
> 
>   $ ./configure --disable-vhost-user --enable-vhost-user-blk ...
>   ../meson.build:761:8: ERROR: Problem encountered: vhost_user_blk_server 
> requires vhost-user support
> 
> Suggested-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> Suggested-by: Alex Bennée <alex.ben...@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
> ---
>  meson.build | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)


Reply via email to