On 11/6/20 10:47 AM, Peter Maydell wrote: >> +#ifndef HOST_WORDS_BIG_ENDIAN >> + bofs ^= 8 | 4; >> +#endif > > The ifdef is HOST_WORDS_BIGENDIAN without the > third underscore, so this XOR operation will be > done on both little and big-endian hosts.
Ho hum. > Should the ifndef line be fixed... This. I once had a patch set that changed all of our endian tests from defined/undef to true/false, so that we could detect errors like this. Perhaps I'll try to recreate it next dev cycle... r~
