On 11/6/20 2:39 PM, Peter Maydell wrote: > On Fri, 6 Nov 2020 at 13:07, Markus Armbruster <[email protected]> wrote: >> The current "warn at 80, error at 90" is a compromise. It's the result >> of a lengthy argument. Why reopen it? > > There was some previous discussion under this thread: > https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg05653.html > > which I think is what prompted this patch.
Can we keep the error please? Maybe 132 is the next display logical limit once we increased the warning from 80 to 100. I understand hardware evolved, we have larger displays with better resolution and can fit more characters in a line. I am a bit wary however functions become heavier (more code into a single function). Maybe this checkpatch change should go with a another one warning when a function has more than 80 lines, excluding comments? (Even 80 is too much for my taste). Regards, Phil.
