Re: [PATCH v2 37/44] qdev: Move qdev_prop_tpm declaration to tpm_prop.h

[Stefan Berger]

On 11/4/20 11:00 AM, Eduardo Habkost wrote:

Move the variable declaration close to the macro that uses it.

Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>

Reviewed-by: Stefan Berger <stef...@linux.ibm.com>

---
Cc: Stefan Berger <stef...@linux.vnet.ibm.com>
Cc: Paolo Bonzini <pbonz...@redhat.com>
Cc: "Daniel P. Berrangé" <berra...@redhat.com>
Cc: Eduardo Habkost <ehabk...@redhat.com>
Cc: qemu-devel@nongnu.org
---
  hw/tpm/tpm_prop.h            | 2 ++
  include/hw/qdev-properties.h | 1 -
  2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/tpm/tpm_prop.h b/hw/tpm/tpm_prop.h
index 85e1ae5718..871af584b7 100644
--- a/hw/tpm/tpm_prop.h
+++ b/hw/tpm/tpm_prop.h
@@ -25,6 +25,8 @@
  #include "sysemu/tpm_backend.h"
  #include "hw/qdev-properties.h"

+extern const PropertyInfo qdev_prop_tpm;

+
  #define DEFINE_PROP_TPMBE(_n, _s, _f)                     \
      DEFINE_PROP(_n, _s, _f, qdev_prop_tpm, TPMBackend *)

diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h

index 2bec65c8e5..c3eaf5e3c5 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -63,7 +63,6 @@ extern const PropertyInfo qdev_prop_uint64;
  extern const PropertyInfo qdev_prop_int64;
  extern const PropertyInfo qdev_prop_size;
  extern const PropertyInfo qdev_prop_string;
-extern const PropertyInfo qdev_prop_tpm;
  extern const PropertyInfo qdev_prop_on_off_auto;
  extern const PropertyInfo qdev_prop_size32;
  extern const PropertyInfo qdev_prop_arraylen;