On Mon, 2 Nov 2020 at 05:12, AlexChen <alex.c...@huawei.com> wrote: > Thanks for your review, I will add this description to my commit message in > my patch V2. > In addition, since the amaster and the aslave are not allow to be NULL, > do we need to check that the amaster and the aslave are NULL in the beginning > of the openpty()?
No, we can just assume it. Our coding style doesn't mandate that level of defensive-coding against caller errors. thanks -- PMM
