Paolo Bonzini <pbonz...@redhat.com> writes: > On 29/10/20 14:38, Markus Armbruster wrote: >> + /* Linux abstract socket */ >> + addr->u.q_unix.path = g_strndup(su->sun_path + 1, >> + sizeof(su->sun_path) - 1); >> + addr->u.q_unix.has_abstract = true; >> + addr->u.q_unix.abstract = true; >> + addr->u.q_unix.has_tight = true; >> + addr->u.q_unix.tight = !su->sun_path[sizeof(su->sun_path) - 1]; >> + return addr; > > I think this should be > > addr->u.q_unit.tight = salen < sizeof(*su); > > Paolo
You're right, my code is wrong. The case "@path just fits" is ambiguous: @tight doesn't matter then. Your code arbitrarily picks tight=false then. Picking the default tight=true would perhaps be a bit nicer. Not worth complicating the code.
