Fix bounds check for idx at freq_to_str(), to actually ensure idx never goes beyond the last element of the suffixes array.
Reported-by: Coverity (CID 1435957: OVERRUN) Suggested-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> --- util/cutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cutils.c b/util/cutils.c index c395974fab..0d9261e1e5 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -891,7 +891,7 @@ char *freq_to_str(uint64_t freq_hz) double freq = freq_hz; size_t idx = 0; - while (freq >= 1000.0 && idx < ARRAY_SIZE(suffixes)) { + while (freq >= 1000.0 && idx < ARRAY_SIZE(suffixes) - 1) { freq /= 1000.0; idx++; } -- 2.28.0