Patchew URL: https://patchew.org/QEMU/20201026143028.3034018-1-pbonz...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201026143028.3034018-1-pbonz...@redhat.com Subject: [PATCH 00/15] remove bios_name variable === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 288a1cc..e75de83 master -> master * [new tag] patchew/20201026143028.3034018-1-pbonz...@redhat.com -> patchew/20201026143028.3034018-1-pbonz...@redhat.com Switched to a new branch 'test' e6a3975 vl: remove bios_name ff23ca8 sparc: remove bios_name 4b04e35 sh4: remove bios_name 35de573 s390: remove bios_name a352220 rx: move BIOS load from MCU to board 83c3173 ppc: remove bios_name c020272 moxie: remove bios_name 09bcdbc mips: remove bios_name c618c9e m68k: remove bios_name 4ff17f7 lm32: remove bios_name c6609bf i386: remove bios_name 2f2d724 hppa: remove bios_name da68a51 arm: remove bios_name 5687239 digic: stash firmware into DigicState 2fae50e alpha: remove bios_name === OUTPUT BEGIN === 1/15 Checking commit 2fae50e6defc (alpha: remove bios_name) 2/15 Checking commit 56872395809e (digic: stash firmware into DigicState) 3/15 Checking commit da68a516b853 (arm: remove bios_name) WARNING: line over 80 characters #37: FILE: hw/arm/highbank.c:299: + sysboot_filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, machine->firmware); total: 0 errors, 1 warnings, 105 lines checked Patch 3/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/15 Checking commit 2f2d724e2d12 (hppa: remove bios_name) WARNING: line over 80 characters #21: FILE: hw/hppa/machine.c:216: + machine->firmware ?: "hppa-firmware.img"); total: 0 errors, 1 warnings, 9 lines checked Patch 4/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/15 Checking commit c6609bf59a25 (i386: remove bios_name) WARNING: line over 80 characters #33: FILE: hw/i386/microvm.c:266: + x86_bios_rom_init(MACHINE(mms), default_firmware, get_system_memory(), true); total: 0 errors, 1 warnings, 75 lines checked Patch 5/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/15 Checking commit 4ff17f7afa49 (lm32: remove bios_name) ERROR: spaces required around that ':' (ctx:VxE) #19: FILE: hw/lm32/milkymist.c:111: + const char *bios_name = machine->firmware ? BIOS_FILENAME: ^ total: 1 errors, 0 warnings, 16 lines checked Patch 6/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/15 Checking commit c618c9eb69d3 (m68k: remove bios_name) 8/15 Checking commit 09bcdbcc744e (mips: remove bios_name) WARNING: line over 80 characters #44: FILE: hw/mips/jazz.c:221: + filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, machine->firmware ?: BIOS_FILENAME); WARNING: line over 80 characters #79: FILE: hw/mips/malta.c:1346: + error_report("Could not load MIPS bios '%s'", machine->firmware); WARNING: line over 80 characters #92: FILE: hw/mips/mipssim.c:180: + filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, machine->firmware ?: BIOS_FILENAME); total: 0 errors, 3 warnings, 89 lines checked Patch 8/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/15 Checking commit c0202725c5bf (moxie: remove bios_name) WARNING: line over 80 characters #22: FILE: hw/moxie/moxiesim.c:137: + if (load_image_targphys(machine->firmware, FIRMWARE_BASE, FIRMWARE_SIZE) < 0) { total: 0 errors, 1 warnings, 12 lines checked Patch 9/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/15 Checking commit 83c31730c9bd (ppc: remove bios_name) 11/15 Checking commit a3522204200e (rx: move BIOS load from MCU to board) 12/15 Checking commit 35de573a9382 (s390: remove bios_name) 13/15 Checking commit 4b04e35c1605 (sh4: remove bios_name) 14/15 Checking commit ff23ca862682 (sparc: remove bios_name) 15/15 Checking commit e6a39752a393 (vl: remove bios_name) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201026143028.3034018-1-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
