On 10/26/20 1:40 PM, Greg Kurz wrote:
If kvmppc_load_htab_chunk() fails, its return value is propagated up
to vmstate_load(). It should thus be a negative errno, not -1 (which
maps to EPERM and would lure the user into thinking that the problem
is necessarily related to a lack of privilege).

Return the error reported by KVM or ENOSPC in case of short write.
While here, propagate the error message through an @errp argument
and have the caller to print it with error_report_err() instead
of relying on fprintf().

Signed-off-by: Greg Kurz <gr...@kaod.org>
---
  hw/ppc/spapr.c       |    4 +++-
  target/ppc/kvm.c     |   11 +++++------
  target/ppc/kvm_ppc.h |    5 +++--
  3 files changed, 11 insertions(+), 9 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>


Reply via email to