On 24/10/20 09:34, Philippe Mathieu-Daudé wrote: >> >> Oops, I took it for granted that the `make check-acceptance` will >> automatically rebuild the QEMU binary, which is not the case. Should >> we enforce the rebuild before testing in Makefiles? > > Well I'm not sure, because I don't want to have to rebuild all > targets before rerunning a single test, but this is a Meson issue > that could be fixed soon. I'll let Cleber/Paolo decide.
It's actually Makefile since check-acceptance is not meson-ified. If you want to add the dependency just write $(filter qemu-system-%, $(ninja-targets)) Paolo > Does that mean I can add your "Tested-by: Bin Meng > <bin.m...@windriver.com>" to the test patches btw?