On Wed, Oct 14, 2020 at 09:54:16AM -0400, Paolo Bonzini wrote: > Now that the build is done entirely by Meson, there is no need > to keep the Makefile conversion. Instead, we can ask Ninja about > the targets it exposes and forward them. > > The main advantages are, from smallest to largest: > > - reducing the possible namespace pollution within the Makefile > > - removal of a relatively large Python program > > - faster build because parsing Makefile.ninja is slower than > parsing build.ninja; and faster build after Meson runs because > we do not have to generate Makefile.ninja. > > - tracking of command lines, which provides more accurate rebuilds > > In addition the change removes the requirement for GNU make 3.82, which > was annoying on Mac, and avoids bugs on Windows due to ninjatool not > knowing how to convert Windows escapes to POSIX escapes. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > Makefile | 40 +- > configure | 9 +- > docs/devel/build-system.rst | 6 +- > meson.build | 4 - > scripts/mtest2make.py | 4 +- > scripts/ninjatool.py | 1008 ----------------------------------- > tests/Makefile.include | 2 +- > 7 files changed, 40 insertions(+), 1033 deletions(-) > delete mode 100755 scripts/ninjatool.py
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
