Patchew URL: https://patchew.org/QEMU/20201012232939.48481-...@getutm.app/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201012232939.48481-...@getutm.app Subject: [PATCH 00/10] iOS and Apple Silicon host support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201012232939.48481-...@getutm.app -> patchew/20201012232939.48481-...@getutm.app Switched to a new branch 'test' b6c449f block: check availablity for preadv/pwritev on mac 86f3837 tcg: support JIT on Apple Silicon 6389bee tcg: mirror mapping RWX pages for iOS optional 8727db6 tcg: implement bulletproof JIT e655897 coroutine: add libucontext as external library e43d59a slirp: update for iOS resolv fix 715f3bd meson: option to build as shared library 7276968 qemu: add support for iOS host 9f6bafb configure: cross-compiling without cross_prefix 9187922 configure: option to disable host block devices === OUTPUT BEGIN === 1/10 Checking commit 9187922c6d93 (configure: option to disable host block devices) WARNING: architecture specific defines should be avoided #22: FILE: block/file-posix.c:44: +#if defined(CONFIG_HOST_BLOCK_DEVICE) && defined(__APPLE__) && (__MACH__) total: 0 errors, 1 warnings, 61 lines checked Patch 1/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/10 Checking commit 9f6bafb19c1d (configure: cross-compiling without cross_prefix) 3/10 Checking commit 72769683dd9c (qemu: add support for iOS host) WARNING: architecture specific defines should be avoided #27: FILE: block.c:56: +#if !defined(__DragonFly__) && !defined(CONFIG_IOS) ERROR: braces {} are necessary for all arms of this statement #45: FILE: block/file-posix.c:189: + if (s->fd >= 0) [...] WARNING: architecture specific defines should be avoided #79: FILE: block/file-posix.c:2325: +#if !defined(CONFIG_IOS) && defined(__APPLE__) && defined(__MACH__) WARNING: architecture specific defines should be avoided #363: FILE: tcg/aarch64/tcg-target.h:151: +#if defined(__APPLE__) WARNING: architecture specific defines should be avoided #369: FILE: tcg/aarch64/tcg-target.h:157: +#if defined(__APPLE__) total: 1 errors, 4 warnings, 316 lines checked Patch 3/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/10 Checking commit 715f3bddd393 (meson: option to build as shared library) 5/10 Checking commit e43d59afc25c (slirp: update for iOS resolv fix) 6/10 Checking commit e655897c7ab2 (coroutine: add libucontext as external library) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #97: new file mode 160000 total: 0 errors, 1 warnings, 140 lines checked Patch 6/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/10 Checking commit 8727db6cfd2d (tcg: implement bulletproof JIT) ERROR: externs should be avoided in .c files #52: FILE: accel/tcg/translate-all.c:65: +extern kern_return_t mach_vm_remap(vm_map_t target_task, WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #189: new file mode 100644 WARNING: architecture specific defines should be avoided #501: FILE: tcg/aarch64/tcg-target.h:171: +#if defined(__APPLE__) WARNING: architecture specific defines should be avoided #757: FILE: tcg/i386/tcg-target.h:209: +#ifdef __APPLE__ WARNING: architecture specific defines should be avoided #768: FILE: tcg/i386/tcg-target.h:220: +#if defined(__APPLE__) total: 1 errors, 4 warnings, 1673 lines checked Patch 7/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/10 Checking commit 6389bee4f3d0 (tcg: mirror mapping RWX pages for iOS optional) 9/10 Checking commit 86f3837d7074 (tcg: support JIT on Apple Silicon) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #206: new file mode 100644 WARNING: architecture specific defines should be avoided #238: FILE: include/tcg/tcg-apple-jit.h:28: +#if defined(__aarch64__) && defined(CONFIG_DARWIN) total: 0 errors, 2 warnings, 259 lines checked Patch 9/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/10 Checking commit b6c449ff37a3 (block: check availablity for preadv/pwritev on mac) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201012232939.48481-...@getutm.app/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
