If we only have a single .c file in a plugin, then define
QEMU_PLUGIN_EXTERN to empty is OK, but if we have multiple .c files
in a plugin, then we need distinguish the implementation and the
deceleration. only the main .c file should define the macro
QEMU_PLUGIN_IMPLEMENTATION
other sources are user and should use extern
Signed-off-by: Yonggang Luo <luoyongg...@gmail.com>
---
contrib/plugins/hotblocks.c | 1 +
contrib/plugins/hotpages.c | 1 +
contrib/plugins/howvec.c | 1 +
contrib/plugins/lockstep.c | 1 +
include/qemu/qemu-plugin.h | 6 ++++++
plugins/core.c | 1 +
tests/plugin/bb.c | 1 +
tests/plugin/empty.c | 1 +
tests/plugin/insn.c | 1 +
tests/plugin/mem.c | 1 +
10 files changed, 15 insertions(+)
diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c
index 37435a3fc7..39e77d2980 100644
--- a/contrib/plugins/hotblocks.c
+++ b/contrib/plugins/hotblocks.c
@@ -13,6 +13,7 @@
#include <stdio.h>
#include <glib.h>
+#define QEMU_PLUGIN_IMPLEMENTATION
#include <qemu-plugin.h>
QEMU_PLUGIN_EXPORT int qemu_plugin_version = QEMU_PLUGIN_VERSION;
diff --git a/contrib/plugins/hotpages.c b/contrib/plugins/hotpages.c
index ecd6c18732..1ae3f44aed 100644
--- a/contrib/plugins/hotpages.c
+++ b/contrib/plugins/hotpages.c
@@ -16,6 +16,7 @@
#include <stdio.h>
#include <glib.h>
+#define QEMU_PLUGIN_IMPLEMENTATION
#include <qemu-plugin.h>
QEMU_PLUGIN_EXPORT int qemu_plugin_version = QEMU_PLUGIN_VERSION;
diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c
index 3b9a6939f2..db1b4e5780 100644
--- a/contrib/plugins/howvec.c
+++ b/contrib/plugins/howvec.c
@@ -18,6 +18,7 @@
#include <stdio.h>
#include <glib.h>
+#define QEMU_PLUGIN_IMPLEMENTATION
#include <qemu-plugin.h>
QEMU_PLUGIN_EXPORT int qemu_plugin_version = QEMU_PLUGIN_VERSION;
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index a696673dff..7173b2910d 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -31,6 +31,7 @@
#include <stdio.h>
#include <errno.h>
+#define QEMU_PLUGIN_IMPLEMENTATION
#include <qemu-plugin.h>
QEMU_PLUGIN_EXPORT int qemu_plugin_version = QEMU_PLUGIN_VERSION;
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index af2f6ccb78..a6ebb295de 100644
--- a/include/qemu/qemu-plugin.h
+++ b/include/qemu/qemu-plugin.h
@@ -426,7 +426,11 @@ typedef void (*qemu_plugin_outs_t)(const char *string);
#if !defined(QEMU_PLUGIN_API_IMPLEMENTATION)
+#if defined(QEMU_PLUGIN_IMPLEMENTATION)
#define qemu_plugin_decl_symbol(symbol_name) symbol_name##_t symbol_name
+#else
+#define qemu_plugin_decl_symbol(symbol_name) extern symbol_name##_t symbol_name
+#endif
#define qemu_plugin_load_symbol(info, symbol_name) do {\
symbol_name = info->dlsym(info->context, #symbol_name); \
@@ -472,6 +476,7 @@ qemu_plugin_decl_symbol(qemu_plugin_n_vcpus);
qemu_plugin_decl_symbol(qemu_plugin_n_max_vcpus);
qemu_plugin_decl_symbol(qemu_plugin_outs);
+#if defined(QEMU_PLUGIN_IMPLEMENTATION)
QEMU_PLUGIN_EXPORT int qemu_plugin_initialize(const qemu_info_t *info)
{
qemu_plugin_load_symbol(info, qemu_plugin_uninstall);
@@ -512,6 +517,7 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_initialize(const
qemu_info_t *info)
qemu_plugin_load_symbol(info, qemu_plugin_outs);
return 0;
}
+#endif /* QEMU_PLUGIN_IMPLEMENTATION */
#endif /* QEMU_PLUGIN_API_IMPLEMENTATION */
diff --git a/plugins/core.c b/plugins/core.c
index 3df3e7d9af..dd1ec7b3fc 100644
--- a/plugins/core.c
+++ b/plugins/core.c
@@ -12,6 +12,7 @@
* SPDX-License-Identifier: GPL-2.0-or-later
*/
#include "qemu/osdep.h"
+#define QEMU_PLUGIN_API_IMPLEMENTATION
#include "qemu/error-report.h"
#include "qemu/config-file.h"
#include "qapi/error.h"
diff --git a/tests/plugin/bb.c b/tests/plugin/bb.c
index de09bdde4e..cda3fbdde9 100644
--- a/tests/plugin/bb.c
+++ b/tests/plugin/bb.c
@@ -12,6 +12,7 @@
#include <stdio.h>
#include <glib.h>
+#define QEMU_PLUGIN_IMPLEMENTATION
#include <qemu-plugin.h>
QEMU_PLUGIN_EXPORT int qemu_plugin_version = QEMU_PLUGIN_VERSION;
diff --git a/tests/plugin/empty.c b/tests/plugin/empty.c
index 8fa6bacd93..0c3adf7aa0 100644
--- a/tests/plugin/empty.c
+++ b/tests/plugin/empty.c
@@ -11,6 +11,7 @@
#include <unistd.h>
#include <stdio.h>
+#define QEMU_PLUGIN_IMPLEMENTATION
#include <qemu-plugin.h>
QEMU_PLUGIN_EXPORT int qemu_plugin_version = QEMU_PLUGIN_VERSION;
diff --git a/tests/plugin/insn.c b/tests/plugin/insn.c
index a9a6e41237..bf86fdafe6 100644
--- a/tests/plugin/insn.c
+++ b/tests/plugin/insn.c
@@ -12,6 +12,7 @@
#include <stdio.h>
#include <glib.h>
+#define QEMU_PLUGIN_IMPLEMENTATION
#include <qemu-plugin.h>
QEMU_PLUGIN_EXPORT int qemu_plugin_version = QEMU_PLUGIN_VERSION;
diff --git a/tests/plugin/mem.c b/tests/plugin/mem.c
index 4725bd851d..f39be9c969 100644
--- a/tests/plugin/mem.c
+++ b/tests/plugin/mem.c
@@ -12,6 +12,7 @@
#include <stdio.h>
#include <glib.h>
+#define QEMU_PLUGIN_IMPLEMENTATION
#include <qemu-plugin.h>
QEMU_PLUGIN_EXPORT int qemu_plugin_version = QEMU_PLUGIN_VERSION;
--
2.28.0.windows.1
