On Mon, Oct 12, 2020 at 03:44:00PM +0200, Philippe Mathieu-Daudé wrote: > Hi Thomas, Alex, > > +Daniel > > On 5/28/20 12:10 PM, Thomas Huth wrote: > > We have a dedicated folder for the gitlab-ci - so there is no need > > to clutter the top directory with these .yml files. > > > > Message-Id: <20200525131823.715-5-th...@redhat.com> > > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > Reviewed-by: Alex Bennée <alex.ben...@linaro.org> > > Signed-off-by: Thomas Huth <th...@redhat.com> > > --- > > .gitlab-ci-edk2.yml => .gitlab-ci.d/edk2.yml | 0 > > .gitlab-ci-opensbi.yml => .gitlab-ci.d/opensbi.yml | 0 > > .gitlab-ci.yml | 4 ++-- > > MAINTAINERS | 2 +- > > 4 files changed, 3 insertions(+), 3 deletions(-) > > rename .gitlab-ci-edk2.yml => .gitlab-ci.d/edk2.yml (100%) > > rename .gitlab-ci-opensbi.yml => .gitlab-ci.d/opensbi.yml (100%) > > > > diff --git a/.gitlab-ci-edk2.yml b/.gitlab-ci.d/edk2.yml > > similarity index 100% > > rename from .gitlab-ci-edk2.yml > > rename to .gitlab-ci.d/edk2.yml > > diff --git a/.gitlab-ci-opensbi.yml b/.gitlab-ci.d/opensbi.yml > > similarity index 100% > > rename from .gitlab-ci-opensbi.yml > > rename to .gitlab-ci.d/opensbi.yml > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > index bc6aee6aba..5208d93ff8 100644 > > --- a/.gitlab-ci.yml > > +++ b/.gitlab-ci.yml > > @@ -1,6 +1,6 @@ > > include: > > - - local: '/.gitlab-ci-edk2.yml' > > - - local: '/.gitlab-ci-opensbi.yml' > > + - local: '/.gitlab-ci.d/edk2.yml' > > + - local: '/.gitlab-ci.d/opensbi.yml' > > It seems these jobs are now always run, the "rules:changes" > to restrict them is ignored. > > I searched a bit and found a plausible explanation here: > https://docs.gitlab.com/ee/ci/yaml/#onlychangesexceptchanges > > "Caution: In pipelines with sources other than the three above changes can’t > determine if a given file is new or old and always returns true. This > includes pipelines triggered by pushing new tags. Configuring jobs to use > only: changes with other only: refs keywords is possible, but not > recommended." > > I don't understand what they mean by "three", is a directory considered > a three? Then that would explain the change.
The edk2.yml file as a "when: always" clause attached to every rule, so surely this negates the point of filtering by making it always run ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
