On 12 August 2011 00:07, Richard Henderson <r...@twiddle.net> wrote: > diff --git a/hw/devices.h b/hw/devices.h > index 07fda83..36c21e7 100644 > --- a/hw/devices.h > +++ b/hw/devices.h > @@ -1,6 +1,9 @@ > #ifndef QEMU_DEVICES_H > #define QEMU_DEVICES_H > > +/* ??? Not all users of this file can include cpu-common.h. */ > +typedef struct MemoryRegion MemoryRegion; > +
This breaks compilation of Avi's memory-region branch: In file included from /home/petmay01/git/qemu/hw/smc91c111.c:12:0: /home/petmay01/git/qemu/hw/devices.h:5:29: error: redefinition of typedef ‘MemoryRegion’ /home/petmay01/git/qemu/memory.h:29:29: note: previous declaration of ‘MemoryRegion’ was here -- PMM