On Sun, 14 Aug 2011 11:45:16 -0500 Anthony Liguori <anth...@codemonkey.ws> wrote:
> On 08/10/2011 03:33 PM, Luiz Capitulino wrote: > > It replaces the VMSTOP macros and allows us to drop some global variables. > > > > Additionally, the problem with issuing 'cont' when the VM is in bad state > > is addressed and we make the current state available in QMP and HMP. > > > > changelog > > --------- > > > > v2 > > > > o Rename the new type from QemuState to RunState > > (also renames related functions) > > o Rename the enum values to contain proper word seperation > > o Redo patch 'Monitor: Don't allow cont on bad VM state' to not use a global > > variable > > o Make the current VM state also available in HMP > > o Improve some commit logs a bit > > Really nice cleanup! > > Other than the few minor naming comments: Will do the changes suggested by you and resend. Thanks for the review. > > Reviewed-by: Anthony Liguori <aligu...@us.ibm.com> > > Regards, > > Anthony Liguori > > > > > audio/audio.c | 2 +- > > cpus.c | 22 ++++++++-------- > > cpus.h | 1 - > > gdbstub.c | 34 ++++++++++++------------ > > hw/etraxfs_dma.c | 2 +- > > hw/ide/ahci.c | 2 +- > > hw/ide/core.c | 4 +- > > hw/ide/internal.h | 3 +- > > hw/ide/pci.c | 2 +- > > hw/kvmclock.c | 5 ++- > > hw/qxl.c | 3 +- > > hw/scsi-disk.c | 4 +- > > hw/virtio-blk.c | 5 ++- > > hw/virtio.c | 4 +- > > hw/watchdog.c | 2 +- > > kvm-all.c | 2 +- > > migration.c | 14 ++++++--- > > monitor.c | 22 +++++++++++---- > > qemu-timer.c | 11 ++++--- > > qerror.c | 4 +++ > > qerror.h | 3 ++ > > qmp-commands.hx | 21 ++++++++++++++- > > savevm.c | 8 +++--- > > sysemu.h | 40 +++++++++++++++++++--------- > > target-i386/kvm.c | 4 +- > > ui/sdl.c | 6 ++-- > > ui/spice-display.c | 3 +- > > vl.c | 71 > > +++++++++++++++++++++++++++++++++++++++++++-------- > > xen-all.c | 8 +++-- > > 29 files changed, 211 insertions(+), 101 deletions(-) > > > > >
