OK
> -----Original Message----- > From: Philippe Mathieu-Daudé <philippe.mathieu.da...@gmail.com> On > Behalf Of Philippe Mathieu-Daudé > Sent: Tuesday, September 29, 2020 5:26 AM > To: Taylor Simpson <tsimp...@quicinc.com>; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v4 15/29] Hexagon (target/hexagon) utility functions > > ------------------------------------------------------------------------- > CAUTION: This email originated from outside of the organization. > ------------------------------------------------------------------------- > > On 9/28/20 7:28 PM, Taylor Simpson wrote: > > Utility functions called by various instructions > > > > Signed-off-by: Taylor Simpson <tsimp...@quicinc.com> > > --- > > target/hexagon/arch.h | 42 +++ > > target/hexagon/conv_emu.h | 50 +++ > > target/hexagon/fma_emu.h | 27 ++ > > target/hexagon/arch.c | 354 +++++++++++++++++++++ > > target/hexagon/conv_emu.c | 369 ++++++++++++++++++++++ > > target/hexagon/fma_emu.c | 777 > ++++++++++++++++++++++++++++++++++++++++++++++ > > 6 files changed, 1619 insertions(+) > > create mode 100644 target/hexagon/arch.h > > create mode 100644 target/hexagon/conv_emu.h > > create mode 100644 target/hexagon/fma_emu.h > > create mode 100644 target/hexagon/arch.c > > create mode 100644 target/hexagon/conv_emu.c > > create mode 100644 target/hexagon/fma_emu.c > > Sorry but I lost focus in the middle of conv_emu.c, > after reviewing arch.c. > > Suggestion to ease review, split in 3 digestible patches: > > 1: > target/hexagon/arch.h > target/hexagon/arch.c > > 2: > target/hexagon/conv_emu.h > target/hexagon/conv_emu.c > > 3: > target/hexagon/fma_emu.h > target/hexagon/fma_emu.c > > Thanks, > > Phil.
