Patchew URL: https://patchew.org/QEMU/20200925172604.2142227-1-pbonz...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200925172604.2142227-1-pbonz...@redhat.com Subject: [PATCH 00/10] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20200925172604.2142227-1-pbonz...@redhat.com -> patchew/20200925172604.2142227-1-pbonz...@redhat.com Switched to a new branch 'test' 9932c24 scsi/scsi_bus: fix races in REPORT LUNS 1b75dae virtio-scsi: use scsi_device_get 5cdf821 scsi/scsi_bus: Add scsi_device_get 47cdfc0 scsi/scsi-bus: scsi_device_find: don't return unrealized devices 75ce260 device-core: use atomic_set on .realized property a417bc2 device-core: use RCU for list of children of a bus 8e81334 device_core: use drain_call_rcu in in hmp_device_del/qmp_device_add ec790ac scsi/scsi_bus: switch search direction in scsi_device_find b9c2f95 scsi: switch to bus->check_address 0519c6e qdev: add "check if address free" callback for buses === OUTPUT BEGIN === 1/10 Checking commit 0519c6ec5850 (qdev: add "check if address free" callback for buses) 2/10 Checking commit b9c2f95892cb (scsi: switch to bus->check_address) ERROR: code indent should never use tabs #53: FILE: hw/scsi/scsi-bus.c:137: +^I^I^I^I int channel, int target, int lun,$ ERROR: code indent should never use tabs #54: FILE: hw/scsi/scsi-bus.c:138: +^I^I^I^I SCSIDevice **p_dev)$ WARNING: line over 80 characters #69: FILE: hw/scsi/scsi-bus.c:153: +static bool scsi_bus_check_address(BusState *qbus, DeviceState *qdev, Error **errp) WARNING: line over 80 characters #89: FILE: hw/scsi/scsi-bus.c:173: + if (!scsi_bus_is_address_free(bus, dev->channel, dev->id, dev->lun, &d)) { WARNING: line over 80 characters #128: FILE: hw/scsi/scsi-bus.c:195: + is_free = scsi_bus_is_address_free(bus, dev->channel, ++id, dev->lun, NULL); WARNING: line over 80 characters #141: FILE: hw/scsi/scsi-bus.c:205: + is_free = scsi_bus_is_address_free(bus, dev->channel, dev->id, ++lun, NULL); total: 2 errors, 4 warnings, 182 lines checked Patch 2/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/10 Checking commit ec790aca5ae9 (scsi/scsi_bus: switch search direction in scsi_device_find) 4/10 Checking commit 8e81334e7b46 (device_core: use drain_call_rcu in in hmp_device_del/qmp_device_add) 5/10 Checking commit a417bc2b8f36 (device-core: use RCU for list of children of a bus) 6/10 Checking commit 75ce26036080 (device-core: use atomic_set on .realized property) 7/10 Checking commit 47cdfc0d2962 (scsi/scsi-bus: scsi_device_find: don't return unrealized devices) 8/10 Checking commit 5cdf82120022 (scsi/scsi_bus: Add scsi_device_get) 9/10 Checking commit 1b75daed11e0 (virtio-scsi: use scsi_device_get) 10/10 Checking commit 9932c24a76f7 (scsi/scsi_bus: fix races in REPORT LUNS) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200925172604.2142227-1-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
