On Tue, Sep 22, 2020 at 02:03:18PM +0200, Miklos Szeredi wrote: > On Mon, Sep 21, 2020 at 11:32 PM Vivek Goyal <vgo...@redhat.com> wrote: > > > glib offers thread pools and it seems to support "exclusive" and "shared" > > thread pools. > > > > > > https://developer.gnome.org/glib/stable/glib-Thread-Pools.html#g-thread-pool-new > > > > Currently we use "exlusive" thread pools but its performance seems to be > > poor. I tried using "shared" thread pools and performance seems much > > better. I posted performance results here. > > > > https://www.redhat.com/archives/virtio-fs/2020-September/msg00080.html > > > > So lets switch to shared thread pools. We can think of making it optional > > once somebody can show in what cases exclusive thread pools offer better > > results. For now, my simple performance tests across the board see > > better results with shared thread pools. > > > > Needs this as well:
I was wondering why I did not face this issue. I think my glib is old (glib2, 2.58.3) from fedora 29 and this change about sched_getattr seems relatively recent. commit 8aeca4fa647bfd0f35c4a86b1e6ca6e955519ca5 Author: Sebastian Dröge <sebast...@centricular.com> Date: Tue Dec 24 15:33:30 2019 +0200 GThreadPool - Don't inherit thread priorities when creating new threads I think my glib2 does not have this change and probably that's why seccomp did not trigger. Vivek > > --- qemu.orig/tools/virtiofsd/passthrough_seccomp.c 2020-09-16 > 20:21:13.168686176 +0200 > +++ qemu/tools/virtiofsd/passthrough_seccomp.c 2020-09-22 > 14:01:38.499164501 +0200 > @@ -94,6 +94,8 @@ static const int syscall_whitelist[] = { > SCMP_SYS(rt_sigaction), > SCMP_SYS(rt_sigprocmask), > SCMP_SYS(rt_sigreturn), > + SCMP_SYS(sched_getattr), > + SCMP_SYS(sched_setattr), > SCMP_SYS(sendmsg), > SCMP_SYS(setresgid), > SCMP_SYS(setresuid), > > Thanks, > Miklos