Peter Maydell <peter.mayd...@linaro.org> writes:
> On Wed, 16 Sep 2020 at 13:27, Alex Bennée <alex.ben...@linaro.org> wrote: >> >> These targets might be deprecated but we should keep them building >> before the final axe comes down. Lets keep them all in one place and >> don't hold up the CI if they do fail. They are either poorly tested or >> already flaky anyway. >> >> Signed-off-by: Alex Bennée <alex.ben...@linaro.org> >> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> Acked-by: Thomas Huth <th...@redhat.com> >> Message-Id: <20200915134317.11110-8-alex.ben...@linaro.org> >> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >> index 72e8604579ee..f027b55aef15 100644 >> --- a/.gitlab-ci.yml >> +++ b/.gitlab-ci.yml >> @@ -254,6 +254,16 @@ build-clang: >> ppc-softmmu s390x-softmmu arm-linux-user >> MAKE_CHECK_ARGS: check >> >> +# These targets are on the way out >> +build-deprecated: >> + <<: *native_build_job_definition >> + variables: >> + IMAGE: debian-all-test-cross >> + CONFIGURE_ARGS: --disable-docs --disable-tools --disable-system >> + MAKE_CHECK_ARGS: check-tcg >> + TARGETS: ppc64abi32-linux-user tilegx-linux-user >> + allow_failure: true > > It's kind of awkward to have the CI config need to be updated when > we mark a config as deprecated. Can we have something so that > the CI just arranges to build all of the deprecated targets? You mean a configure --enable-deprecated-targets? > > (As demonstration, this list is missing unicore32, which is also > deprecated.) That was fixed up in the next patch. > Also, "allow_failure: true" seems wrong to me. These targets > are only deprecated, which means we promise that the feature > should still work (to whatever extent it already did) for the 2 > releases in which it is deprecated. We want our CI to tell us > if it fails to compile or fails tests, because we would need to > fix those bugs for a release. I can revert that bit. -- Alex Bennée
