On Fri, 11 Sep 2020 23:37:48 +0530
Ani Sinha <a...@anisinha.ca> wrote:
> Ability to turn hotplug off on the pci root bus for i440fx was added in
> commit:
> 3d7e78aa7777f0 ("Introduce a new flag for i440fx to disable PCI hotplug on
> the root bus")
>
> This change adds a unit test in order to test this feature.
>
> This change has been tested against upstream qemu master branch on top of tag
> v5.1.0.
isn't this seriest a rebase on top of master?
should comment be amended?
>
> Signed-off-by: Ani Sinha <a...@anisinha.ca>
Reviewed-by: Igor Mammedov <imamm...@redhat.com>
> ---
> tests/qtest/bios-tables-test.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 504b810af5..d8c7d57557 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -740,6 +740,20 @@ static void test_acpi_piix4_tcg_bridge(void)
> free_test_data(&data);
> }
>
> +static void test_acpi_piix4_root_hotplug(void)
> +{
> + test_data data;
> +
> + memset(&data, 0, sizeof(data));
> + data.machine = MACHINE_PC;
> + data.variant = ".roothp";
> + data.required_struct_types = base_required_struct_types;
> + data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types);
> + test_acpi_one("-global PIIX4_PM.acpi-root-pci-hotplug=off "
> + "-device pci-bridge,chassis_nr=1", &data);
> + free_test_data(&data);
> +}
> +
> static void test_acpi_q35_tcg(void)
> {
> test_data data;
> @@ -1144,6 +1158,7 @@ int main(int argc, char *argv[])
> qtest_add_func("acpi/q35/tpm-tis", test_acpi_q35_tcg_tpm_tis);
> qtest_add_func("acpi/piix4", test_acpi_piix4_tcg);
> qtest_add_func("acpi/piix4/bridge", test_acpi_piix4_tcg_bridge);
> + qtest_add_func("acpi/piix4/hotplug", test_acpi_piix4_root_hotplug);
> qtest_add_func("acpi/q35", test_acpi_q35_tcg);
> qtest_add_func("acpi/q35/bridge", test_acpi_q35_tcg_bridge);
> qtest_add_func("acpi/q35/mmio64", test_acpi_q35_tcg_mmio64);
