On Wed, Sep 9, 2020 at 8:56 PM Daniel P. Berrangé <berra...@redhat.com>
wrote:
> On Wed, Sep 09, 2020 at 05:46:03PM +0800, Yonggang Luo wrote:
> > On Windows there is no path like /tmp/s_local_disk.XXXXXX
> > Use g_get_tmp_dir instead of /tmp.
> >
> > Signed-off-by: Yonggang Luo <luoyongg...@gmail.com>
> > ---
> > tests/test-replication.c | 18 ++++++++++++++----
> > 1 file changed, 14 insertions(+), 4 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
>
>
> > @@ -571,6 +571,11 @@ static void setup_sigabrt_handler(void)
> > int main(int argc, char **argv)
> > {
> > int ret;
> > + const char *tmpdir = g_get_tmp_dir();
> > + p_local_disk = g_strdup_printf("%s/p_local_disk.XXXXXX", tmpdir);
> > + s_local_disk = g_strdup_printf("%s/s_local_disk.XXXXXX", tmpdir);
> > + s_active_disk = g_strdup_printf("%s/s_active_disk.XXXXXX", tmpdir);
> > + s_hidden_disk = g_strdup_printf("%s/s_hidden_disk.XXXXXX", tmpdir);
>
> I presume msys is taking care of translating "/" into "\" so that
> we don't need to use g_build_filename to use the native directory
> separator straightaway ?
>
Not only msys2, but also win32 api can recoginize "/", so we doesn't need
to care about it
>
>
> Regards,
> Daniel
> --
> |: https://berrange.com -o-
> https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o-
> https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o-
> https://www.instagram.com/dberrange :|
>
>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
