On Wed, Sep 02, 2020 at 08:33:35AM +0200, Igor Mammedov wrote:
> On Wed, 2 Sep 2020 11:48:00 +0530
> Ani Sinha <a...@anisinha.ca> wrote:
>
> > On Tue, Sep 1, 2020 at 8:39 PM Ani Sinha <a...@anisinha.ca> wrote:
> > >
> > > A new binary ACPI table tests/data/acpi/pc/DSDT.roothp is added in order
> > > to unit test hotplug on/off capability on the root pci bus for i440fx.
> > > The diff between the table DSDT.bridge and DSDT.roothp is listed below:
> > >
> > > @@ -1,30 +1,30 @@
> > > /*
> > > * Intel ACPI Component Architecture
> > > * AML/ASL+ Disassembler version 20180105 (64-bit version)
> > > * Copyright (c) 2000 - 2018 Intel Corporation
> > > *
> > > * Disassembling to symbolic ASL+ operators
> > > *
> > > - * Disassembly of tests/data/acpi/pc/DSDT.bridge, Tue Sep 1 20:02:44
> > > 2020
> > > + * Disassembly of /tmp/aml-4FIZP0, Tue Sep 1 20:02:44 2020
> > > *
> > > * Original Table Header:
> > > * Signature "DSDT"
> > > - * Length 0x00001A89 (6793)
> > > + * Length 0x0000140A (5130)
> > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math
> > > support
> > > - * Checksum 0x08
> > > + * Checksum 0xE5
> > > * OEM ID "BOCHS "
> > > * OEM Table ID "BXPCDSDT"
> > > * OEM Revision 0x00000001 (1)
> > > * Compiler ID "BXPC"
> > > * Compiler Version 0x00000001 (1)
> > > */
> > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)
> > > {
> > > Scope (\)
> > > {
> > > OperationRegion (DBG, SystemIO, 0x0402, One)
> > > Field (DBG, ByteAcc, NoLock, Preserve)
> > > {
> > > DBGB, 8
> > > }
> > >
> > > @@ -831,61 +831,60 @@
> > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource
> > > Settings
> > > {
> > > IO (Decode16,
> > > 0x0510, // Range Minimum
> > > 0x0510, // Range Maximum
> > > 0x01, // Alignment
> > > 0x0C, // Length
> > > )
> > > })
> > > }
> > > }
> > >
> > > Scope (\_SB)
> > > {
> > > Scope (PCI0)
> > > {
> > > - Name (BSEL, Zero)
> > > Device (S00)
> > > {
> > > Name (_ADR, Zero) // _ADR: Address
> > > }
> > >
> > > Device (S10)
> > > {
> > > Name (_ADR, 0x00020000) // _ADR: Address
> > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State
> > > {
> > > Return (Zero)
> > > }
> > >
> > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State
> > > {
> > > Return (Zero)
> > > }
> > >
> > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State
> > > {
> > > Return (Zero)
> > > }
> > > }
> > >
> > > Device (S18)
> > > {
> > > Name (_ADR, 0x00030000) // _ADR: Address
> > > - Name (BSEL, One)
> > > + Name (BSEL, Zero)
> > The bsel numbering is now starting from 0 for the bridge. I believe
> > this is because
> >
> > *bus_bsel = (*bsel_alloc)++;
> >
> > The increment never happens for the root bus since the root bus is not
> > hotpluggable.
>
> considering it needs an optional CLI option, it shouldn't be an issue.
Right. Defaults didn't change.
--
MST
