Paolo Bonzini <pbonz...@redhat.com> writes:
> Il gio 3 set 2020, 13:21 Alex Bennée <alex.ben...@linaro.org> ha scritto:
>
>> As the tests build only softfloat.c no actual TCG machinary is neede
>> to test them (as is evidenced by GCC check-softfloat). Might as well
>> fix the wording on Travis while at it.
>>
>
> The reason is that softfloat is not built at all into QEMU if !CONFIG_TCG.
> We similarly skip block layer tests if !CONFIG_SOFTMMU &&
> !CONFIG_TOOLS.
It's not built anyway if you don't call the test. Are you saying a
--disable-system and --disable-user build is invalid for running unit
tests? That is what check-softfloat is doing as it doesn't involve
softfloat built into any qemu binary.
>
> Paolo
>
>
>> Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
>> ---
>> .travis.yml | 2 +-
>> tests/meson.build | 3 ++-
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 1d0ade0a133..65341634d02 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -138,7 +138,7 @@ jobs:
>>
>>
>> # Just build tools and run minimal unit and softfloat checks
>> - - name: "GCC check-softfloat (user)"
>> + - name: "GCC check-unit and check-softfloat"
>> env:
>> - BASE_CONFIG="--enable-tools"
>> - CONFIG="--disable-user --disable-system"
>> diff --git a/tests/meson.build b/tests/meson.build
>> index fe2c6d8e6b6..bdcc5d75293 100644
>> --- a/tests/meson.build
>> +++ b/tests/meson.build
>> @@ -7,8 +7,9 @@ test('decodetree', sh,
>> workdir: meson.current_source_dir() / 'decode',
>> suite: 'decodetree')
>>
>> +subdir('fp')
>> +
>> if 'CONFIG_TCG' in config_host
>> - subdir('fp')
>> if 'CONFIG_PLUGIN' in config_host
>> subdir('plugin')
>> endif
>> --
>> 2.20.1
>>
>>
--
Alex Bennée
