On 02/09/20 10:24, Philippe Mathieu-Daudé wrote:
>> - helper = bridge->has_helper ? bridge->helper : DEFAULT_BRIDGE_HELPER;
>> + if (!bridge->has_helper) {
>> + helper = default_helper = get_relocated_path(DEFAULT_BRIDGE_HELPER);
>> + } else {
>> + helper = bridge->helper;
>> + }
> Nitpicking, I find easier to review adding simply once after out of the
> if() statement:
>
> helper = bridge->helper;
>
Even better,
- helper = bridge->has_helper ? bridge->helper : DEFAULT_BRIDGE_HELPER;
+ helper = bridge->has_helper ? bridge->helper : NULL;
and move the get_relocated_path in net_bridge_run_helper.
Paolo
