On Tue, Sep 1, 2020 at 10:55 PM Peter Xu <pet...@redhat.com> wrote:
>
> On Tue, Sep 01, 2020 at 04:26:05PM +0200, Eugenio Pérez wrote:
> > This way we can tell between regulars IOMMURLBEntries (entry of IOMMU
> > hardware) and notifications.
>
> s/regulars IOMMURLBEntries/regular IOMMUTLBEntry/
>
> >
> > In the notifications, we set explicitly if it is a MAPs or an UNMAP,
> > instead of trusting in entry permissions to differenciate them.
> >
> > Signed-off-by: Eugenio Pérez <epere...@redhat.com>
>
> [...]
>
> > struct IOMMUTLBEntry {
> > - AddressSpace *target_as;
> > - hwaddr iova;
> > - hwaddr translated_addr;
> > - hwaddr addr_mask; /* 0xfff = 4k translation */
> > - IOMMUAccessFlags perm;
> > + AddressSpace *target_as;
> > + hwaddr iova;
> > + hwaddr translated_addr;
> > + hwaddr addr_mask; /* 0xfff = 4k translation */
> > + IOMMUAccessFlags perm;
> > };
>
> If these lines are identical, then we can avoid touching the spaces.
>
Thanks for the catches! Didn't notice them rebasing.
> With above changes, please feel free to add:
>
> Reviewed-by: Peter Xu <pet...@redhat.com>
>
> --
> Peter Xu
>
